diff mbox

[edk2,4/5] OvmfPkg/PciHostBridgeLib: silence IA32 VS2015x86 warnings

Message ID 1468570456-15031-5-git-send-email-lersek@redhat.com
State Accepted
Commit f982bb8d627ed37ee14b9f0b8bc6a0b3a22c75e5
Headers show

Commit Message

Laszlo Ersek July 15, 2016, 8:14 a.m. UTC 
When compiling "OvmfPkg\Library\PciHostBridgeLib\XenSupport.c" for IA32,
the VS2015x86 compiler emits the following:

> XenSupport.c(41): error C2220: warning treated as error - no 'object'

>                                file generated

> XenSupport.c(41): warning C4244: 'function': conversion from 'UINT64' to

>                                  'UINTN', possible loss of data

> XenSupport.c(48): warning C4244: 'function': conversion from 'UINT64' to

>                                  'UINTN', possible loss of data

> XenSupport.c(49): warning C4244: 'function': conversion from 'UINT64' to

>                                  'UINTN', possible loss of data

> XenSupport.c(50): warning C4244: 'function': conversion from 'UINT64' to

>                                  'UINTN', possible loss of data

> XenSupport.c(222): warning C4244: 'function': conversion from 'UINT64'

>                                   to 'UINTN', possible loss of data

> XenSupport.c(241): warning C4244: 'function': conversion from 'UINT64'

>                                   to 'UINTN', possible loss of data


PciLib functions take UINTN addresses that were encoded with the
PCI_LIB_ADDRESS() macro. We carry addresses from the macro invocations to
the function calls in two UINT64 variables however. This loses no data,
but it alerts VS2015x86. Change the variable types to UINTN.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>

---
 OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
1.8.3.1


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
index 21896637e051..31c63ae19e0a 100644
--- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
+++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
@@ -30,7 +30,7 @@ 
 STATIC
 VOID
 PcatPciRootBridgeBarExisted (
-  IN  UINT64                         Address,
+  IN  UINTN                          Address,
   OUT UINT32                         *OriginalValue,
   OUT UINT32                         *Value
   )
@@ -180,7 +180,7 @@  ScanForRootBridges (
   UINT8      Device;
   UINT8      Function;
   UINTN      NumberOfDevices;
-  UINT64     Address;
+  UINTN      Address;
   PCI_TYPE01 Pci;
   UINT64     Attributes;
   UINT64     Base;