| Message ID | 20230904104046.1682875-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 7523d330aac7190f738998a52df8d5aa14293280 |
| Headers | show |
| Series | [v1,1/1] device property: Clarify usage scope of some struct fwnode_handle members | expand |
On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote: > Most of the struct fwnode_handle members are for exclusive use with > device links framework. Clarify this by adding a respective comment. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Yes, this is important clarification. Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > include/linux/fwnode.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h > index 5700451b300f..2a72f55d26eb 100644 > --- a/include/linux/fwnode.h > +++ b/include/linux/fwnode.h > @@ -41,6 +41,8 @@ struct device; > struct fwnode_handle { > struct fwnode_handle *secondary; > const struct fwnode_operations *ops; > + > + /* The below is used solely by device links, don't use otherwise */ > struct device *dev; > struct list_head suppliers; > struct list_head consumers; > -- > 2.40.0.1.gaa8946217a0b
On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote: > Most of the struct fwnode_handle members are for exclusive use with > device links framework. Clarify this by adding a respective comment. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote: > Most of the struct fwnode_handle members are for exclusive use with > device links framework. Clarify this by adding a respective comment. Thank you, folks, for the review. Rafael, Greg, who can apply this?
On Mon, Sep 18, 2023 at 07:59:55PM +0300, Andy Shevchenko wrote: > On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote: > > Most of the struct fwnode_handle members are for exclusive use with > > device links framework. Clarify this by adding a respective comment. > > Thank you, folks, for the review. Rafael, Greg, who can apply this? I will, give me some time to catch up with my pending patch queue. greg k-h
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 5700451b300f..2a72f55d26eb 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -41,6 +41,8 @@ struct device; struct fwnode_handle { struct fwnode_handle *secondary; const struct fwnode_operations *ops; + + /* The below is used solely by device links, don't use otherwise */ struct device *dev; struct list_head suppliers; struct list_head consumers;
Most of the struct fwnode_handle members are for exclusive use with device links framework. Clarify this by adding a respective comment. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/fwnode.h | 2 ++ 1 file changed, 2 insertions(+)