diff mbox series

[1/3] dt-bindings: power: syscon-poweroff: get regmap from parent node

Message ID 20230901120057.47018-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 716293381a0f9a400d0010628a9ba4354c2bea40
Headers show
Series [1/3] dt-bindings: power: syscon-poweroff: get regmap from parent node | expand

Commit Message

Krzysztof Kozlowski Sept. 1, 2023, noon UTC
Just like syscon-reboot device, the syscon-poweroff is supposed to be a
child of syscon node, thus we can take the same approach as
syscon-poweroff: deprecate the 'regmap' field in favor of taking it from
the parent's node.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

See also syscon-regmap:
https://lore.kernel.org/all/20200526135102.21236-1-Sergey.Semin@baikalelectronics.ru/
---
 .../bindings/power/reset/syscon-poweroff.yaml          | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Sebastian Reichel Sept. 12, 2023, 7:08 p.m. UTC | #1
On Fri, 01 Sep 2023 14:00:55 +0200, Krzysztof Kozlowski wrote:
> Just like syscon-reboot device, the syscon-poweroff is supposed to be a
> child of syscon node, thus we can take the same approach as
> syscon-poweroff: deprecate the 'regmap' field in favor of taking it from
> the parent's node.
> 
> 

Applied, thanks!

[1/3] dt-bindings: power: syscon-poweroff: get regmap from parent node
      commit: 716293381a0f9a400d0010628a9ba4354c2bea40
[2/3] power: reset: syscon-poweroff: simplify pdev->dev usage
      commit: 6f9c8a1338d90d150767331d4fab051fb8abdba5
[3/3] power: reset: syscon-poweroff: get regmap from parent node
      commit: 92bbb93aaaefe14c01eac18df46f8260ee4c2825

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
index 3412fe7e1e80..3c58f8251882 100644
--- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
+++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
@@ -15,6 +15,9 @@  description: |+
   defined by the register map pointed by syscon reference plus the offset
   with the value and mask defined in the poweroff node.
   Default will be little endian mode, 32 bit access only.
+  The SYSCON registers map is normally retrieved from the parental dt-node. So
+  the SYSCON poweroff node should be represented as a sub-node of a "syscon",
+  "simple-mfd" node.
 
 properties:
   compatible:
@@ -30,7 +33,10 @@  properties:
 
   regmap:
     $ref: /schemas/types.yaml#/definitions/phandle
-    description: Phandle to the register map node.
+    deprecated: true
+    description:
+      Phandle to the register map node. This property is deprecated in favor of
+      the syscon-poweroff node been a child of a system controller node.
 
   value:
     $ref: /schemas/types.yaml#/definitions/uint32
@@ -38,7 +44,6 @@  properties:
 
 required:
   - compatible
-  - regmap
   - offset
 
 additionalProperties: false
@@ -56,7 +61,6 @@  examples:
   - |
     poweroff {
         compatible = "syscon-poweroff";
-        regmap = <&regmapnode>;
         offset = <0x0>;
         mask = <0x7a>;
     };