diff mbox series

[v8,2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control

Message ID 20230830123202.3408318-3-billy_tsai@aspeedtech.com
State Superseded
Headers show
Series Support pwm/tach driver for aspeed ast26xx | expand

Commit Message

Billy Tsai Aug. 30, 2023, 12:32 p.m. UTC 
Document the compatible for aspeed,ast2600-pwm-tach device, which can
support up to 16 PWM outputs and 16 fan tach input.

Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
 .../bindings/hwmon/aspeed,g6-pwm-tach.yaml    | 67 +++++++++++++++++++
 1 file changed, 67 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml

Comments

Billy Tsai Sept. 7, 2023, 7:24 a.m. UTC | #1 
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/aspeed-clock.h>
>> +    pwm_tach: pwm-tach-controller@1e610000 {
>> +      compatible = "aspeed,ast2600-pwm-tach";
>> +      reg = <0x1e610000 0x100>;
>> +      clocks = <&syscon ASPEED_CLK_AHB>;
>> +      resets = <&syscon ASPEED_RESET_PWM>;
>> +      #pwm-cells = <3>;

> Blank line.

>> +      fan0_hwmon {
>> +        tach-ch = <0x0>;

> Don't you need 'pwms'?

Yes, I only want to create the fan monitor without fan control.

> +      };
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml
new file mode 100644
index 000000000000..95bac5588c04
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml
@@ -0,0 +1,67 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2021 Aspeed, Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/aspeed,g6-pwm-tach.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASPEED G6 PWM and Fan Tach controller device driver
+
+maintainers:
+  - Billy Tsai <billy_tsai@aspeedtech.com>
+
+description: |
+  The ASPEED PWM controller can support up to 16 PWM outputs.
+  The ASPEED Fan Tacho controller can support up to 16 fan tach input.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2600-pwm-tach
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 3
+
+patternProperties:
+  "^fan[0-9a-f]_hwmon+$":
+    $ref: fan-common.yaml#
+    required:
+      - tach-ch
+
+required:
+  - reg
+  - clocks
+  - resets
+  - "#pwm-cells"
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    pwm_tach: pwm-tach-controller@1e610000 {
+      compatible = "aspeed,ast2600-pwm-tach";
+      reg = <0x1e610000 0x100>;
+      clocks = <&syscon ASPEED_CLK_AHB>;
+      resets = <&syscon ASPEED_RESET_PWM>;
+      #pwm-cells = <3>;
+      fan0_hwmon {
+        tach-ch = <0x0>;
+      };
+      fan1_hwmon {
+        tach-ch = <0x1>;
+      };
+      fan2_hwmon {
+        tach-ch = <0x2>;
+      };
+    };