diff mbox series

[-next] crypto: qat - Use list_for_each_entry() helper

Message ID 20230830075451.293379-1-ruanjinjie@huawei.com
State Accepted
Commit 65029eec5ceba7d847f27171cdddb046bdc3a069
Headers show
Series [-next] crypto: qat - Use list_for_each_entry() helper | expand

Commit Message

Jinjie Ruan Aug. 30, 2023, 7:54 a.m. UTC 
Convert list_for_each() to list_for_each_entry() so that the list_itr
list_head pointer and list_entry() call are no longer needed, which
can reduce a few lines of code. No functional changed.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 .../crypto/intel/qat/qat_common/adf_init.c    | 24 +++++--------------
 1 file changed, 6 insertions(+), 18 deletions(-)

Comments

Andy Shevchenko Aug. 31, 2023, 1:42 p.m. UTC | #1 
On Wed, Aug 30, 2023 at 03:54:51PM +0800, Jinjie Ruan wrote:
> Convert list_for_each() to list_for_each_entry() so that the list_itr
> list_head pointer and list_entry() call are no longer needed, which
> can reduce a few lines of code. No functional changed.

Seems correct to me, assumed that this has been tested,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cabiddu, Giovanni Aug. 31, 2023, 4:47 p.m. UTC | #2 
On Thu, Aug 31, 2023 at 04:42:44PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 30, 2023 at 03:54:51PM +0800, Jinjie Ruan wrote:
> > Convert list_for_each() to list_for_each_entry() so that the list_itr
> > list_head pointer and list_entry() call are no longer needed, which
> > can reduce a few lines of code. No functional changed.
> 
> Seems correct to me, assumed that this has been tested,
Seems correct also to me. I also tried it and it works.

Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Regards,
Herbert Xu Sept. 15, 2023, 10:40 a.m. UTC | #3 
On Wed, Aug 30, 2023 at 03:54:51PM +0800, Jinjie Ruan wrote:
> Convert list_for_each() to list_for_each_entry() so that the list_itr
> list_head pointer and list_entry() call are no longer needed, which
> can reduce a few lines of code. No functional changed.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>  .../crypto/intel/qat/qat_common/adf_init.c    | 24 +++++--------------
>  1 file changed, 6 insertions(+), 18 deletions(-)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/intel/qat/qat_common/adf_init.c b/drivers/crypto/intel/qat/qat_common/adf_init.c
index 89001fe92e76..79a81e25de97 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_init.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_init.c
@@ -61,7 +61,6 @@  int adf_service_unregister(struct service_hndl *service)
 static int adf_dev_init(struct adf_accel_dev *accel_dev)
 {
 	struct service_hndl *service;
-	struct list_head *list_itr;
 	struct adf_hw_device_data *hw_data = accel_dev->hw_device;
 	int ret;
 
@@ -137,8 +136,7 @@  static int adf_dev_init(struct adf_accel_dev *accel_dev)
 	 * This is to facilitate any ordering dependencies between services
 	 * prior to starting any of the accelerators.
 	 */
-	list_for_each(list_itr, &service_table) {
-		service = list_entry(list_itr, struct service_hndl, list);
+	list_for_each_entry(service, &service_table, list) {
 		if (service->event_hld(accel_dev, ADF_EVENT_INIT)) {
 			dev_err(&GET_DEV(accel_dev),
 				"Failed to initialise service %s\n",
@@ -165,7 +163,6 @@  static int adf_dev_start(struct adf_accel_dev *accel_dev)
 {
 	struct adf_hw_device_data *hw_data = accel_dev->hw_device;
 	struct service_hndl *service;
-	struct list_head *list_itr;
 	int ret;
 
 	set_bit(ADF_STATUS_STARTING, &accel_dev->status);
@@ -209,8 +206,7 @@  static int adf_dev_start(struct adf_accel_dev *accel_dev)
 
 	adf_heartbeat_start(accel_dev);
 
-	list_for_each(list_itr, &service_table) {
-		service = list_entry(list_itr, struct service_hndl, list);
+	list_for_each_entry(service, &service_table, list) {
 		if (service->event_hld(accel_dev, ADF_EVENT_START)) {
 			dev_err(&GET_DEV(accel_dev),
 				"Failed to start service %s\n",
@@ -259,7 +255,6 @@  static void adf_dev_stop(struct adf_accel_dev *accel_dev)
 {
 	struct adf_hw_device_data *hw_data = accel_dev->hw_device;
 	struct service_hndl *service;
-	struct list_head *list_itr;
 	bool wait = false;
 	int ret;
 
@@ -280,8 +275,7 @@  static void adf_dev_stop(struct adf_accel_dev *accel_dev)
 	if (!list_empty(&accel_dev->compression_list))
 		qat_comp_algs_unregister();
 
-	list_for_each(list_itr, &service_table) {
-		service = list_entry(list_itr, struct service_hndl, list);
+	list_for_each_entry(service, &service_table, list) {
 		if (!test_bit(accel_dev->accel_id, service->start_status))
 			continue;
 		ret = service->event_hld(accel_dev, ADF_EVENT_STOP);
@@ -318,7 +312,6 @@  static void adf_dev_shutdown(struct adf_accel_dev *accel_dev)
 {
 	struct adf_hw_device_data *hw_data = accel_dev->hw_device;
 	struct service_hndl *service;
-	struct list_head *list_itr;
 
 	if (!hw_data) {
 		dev_err(&GET_DEV(accel_dev),
@@ -340,8 +333,7 @@  static void adf_dev_shutdown(struct adf_accel_dev *accel_dev)
 				  &accel_dev->status);
 	}
 
-	list_for_each(list_itr, &service_table) {
-		service = list_entry(list_itr, struct service_hndl, list);
+	list_for_each_entry(service, &service_table, list) {
 		if (!test_bit(accel_dev->accel_id, service->init_status))
 			continue;
 		if (service->event_hld(accel_dev, ADF_EVENT_SHUTDOWN))
@@ -378,10 +370,8 @@  static void adf_dev_shutdown(struct adf_accel_dev *accel_dev)
 int adf_dev_restarting_notify(struct adf_accel_dev *accel_dev)
 {
 	struct service_hndl *service;
-	struct list_head *list_itr;
 
-	list_for_each(list_itr, &service_table) {
-		service = list_entry(list_itr, struct service_hndl, list);
+	list_for_each_entry(service, &service_table, list) {
 		if (service->event_hld(accel_dev, ADF_EVENT_RESTARTING))
 			dev_err(&GET_DEV(accel_dev),
 				"Failed to restart service %s.\n",
@@ -393,10 +383,8 @@  int adf_dev_restarting_notify(struct adf_accel_dev *accel_dev)
 int adf_dev_restarted_notify(struct adf_accel_dev *accel_dev)
 {
 	struct service_hndl *service;
-	struct list_head *list_itr;
 
-	list_for_each(list_itr, &service_table) {
-		service = list_entry(list_itr, struct service_hndl, list);
+	list_for_each_entry(service, &service_table, list) {
 		if (service->event_hld(accel_dev, ADF_EVENT_RESTARTED))
 			dev_err(&GET_DEV(accel_dev),
 				"Failed to restart service %s.\n",