| Message ID | 20230826095113.1137177-1-liaochang1@huawei.com |
|---|---|
| State | Accepted |
| Commit | 03997da042dac73c69e60d91942c727c76828b65 |
| Headers | show |
| Series | cpufreq: powernow-k8: Use related_cpus instead of cpus in driver.exit() | expand |
On 26-08-23, 09:51, Liao Chang wrote: > Since the 'cpus' field of policy structure will become empty in the > cpufreq core API, it is better to use 'related_cpus' in the exit() > callback of driver. > > Fixes: c3274763bfc3 ("cpufreq: powernow-k8: Initialize per-cpu data-structures properly") > Signed-off-by: Liao Chang <liaochang1@huawei.com> > --- > drivers/cpufreq/powernow-k8.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c > index d289036beff2..b10f7a1b77f1 100644 > --- a/drivers/cpufreq/powernow-k8.c > +++ b/drivers/cpufreq/powernow-k8.c > @@ -1101,7 +1101,8 @@ static int powernowk8_cpu_exit(struct cpufreq_policy *pol) > > kfree(data->powernow_table); > kfree(data); > - for_each_cpu(cpu, pol->cpus) > + /* pol->cpus will be empty here, use related_cpus instead. */ > + for_each_cpu(cpu, pol->related_cpus) > per_cpu(powernow_data, cpu) = NULL; > > return 0; Applied. Thanks.
diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index d289036beff2..b10f7a1b77f1 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -1101,7 +1101,8 @@ static int powernowk8_cpu_exit(struct cpufreq_policy *pol) kfree(data->powernow_table); kfree(data); - for_each_cpu(cpu, pol->cpus) + /* pol->cpus will be empty here, use related_cpus instead. */ + for_each_cpu(cpu, pol->related_cpus) per_cpu(powernow_data, cpu) = NULL; return 0;
Since the 'cpus' field of policy structure will become empty in the cpufreq core API, it is better to use 'related_cpus' in the exit() callback of driver. Fixes: c3274763bfc3 ("cpufreq: powernow-k8: Initialize per-cpu data-structures properly") Signed-off-by: Liao Chang <liaochang1@huawei.com> --- drivers/cpufreq/powernow-k8.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)