| Message ID | 20230823182401.196270-1-dmantipov@yandex.ru |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] wifi: ath9k: simplify ar9003_hw_process_ini() | expand |
Dmitry Antipov <dmantipov@yandex.ru> writes: > Since commit 8896934c1684 ("ath9k_hw: remove direct accesses to channel > mode flags") changes 'ar9550_hw_get_modes_txgain_index()' so it never > returns -EINVAL, and 'ar9561_hw_get_modes_txgain_index()' never returns > negative value too, an extra check in 'ar9003_hw_process_ini()' may be > dropped. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Dmitry Antipov <dmantipov@yandex.ru> wrote: > Since commit 8896934c1684 ("ath9k_hw: remove direct accesses to channel > mode flags") changes 'ar9550_hw_get_modes_txgain_index()' so it never > returns -EINVAL, and 'ar9561_hw_get_modes_txgain_index()' never returns > negative value too, an extra check in 'ar9003_hw_process_ini()' may be > dropped. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> > Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Acked-by: Toke Høiland-Jørgensen <toke@toke.dk> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> 2 patches applied to ath-next branch of ath.git, thanks. e6a1107bf5eb wifi: ath9k: simplify ar9003_hw_process_ini() 352281e4a0a0 wifi: ath9k: use u32 for txgain indexes
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c index a29c11f944a5..4731e6618209 100644 --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c @@ -925,9 +925,6 @@ static int ar9003_hw_process_ini(struct ath_hw *ah, modes_txgain_index = ar9561_hw_get_modes_txgain_index(ah, chan); - if (modes_txgain_index < 0) - return -EINVAL; - REG_WRITE_ARRAY(&ah->iniModesTxGain, modes_txgain_index, regWrites); } else {
Since commit 8896934c1684 ("ath9k_hw: remove direct accesses to channel mode flags") changes 'ar9550_hw_get_modes_txgain_index()' so it never returns -EINVAL, and 'ar9561_hw_get_modes_txgain_index()' never returns negative value too, an extra check in 'ar9003_hw_process_ini()' may be dropped. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> --- drivers/net/wireless/ath/ath9k/ar9003_phy.c | 3 --- 1 file changed, 3 deletions(-)