| Message ID | 20230823113254.292603-2-danishanwar@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce IEP driver and packet timestamping support | expand |
On 23/08/2023 13:32, MD Danish Anwar wrote: > Add a DT binding document for the ICSS Industrial Ethernet Peripheral(IEP) > hardware. IEP supports packet timestamping, PTP and PPS. > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Really? Where? > Reviewed-by: Roger Quadros <rogerq@kernel.org> Now you are making things up. Please stop faking tags. > Reviewed-by: Simon Horman <horms@kernel.org> Where? > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > --- > .../devicetree/bindings/net/ti,icss-iep.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml > > diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml > new file mode 100644 > index 000000000000..75668bea8614 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module > + > +maintainers: > + - Md Danish Anwar <danishanwar@ti.com> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - ti,am642-icss-iep > + - ti,j721e-icss-iep > + - const: ti,am654-icss-iep > + > + - const: ti,am654-icss-iep > + > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: phandle to the IEP source clock > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + Drop stray blank line > + /* AM65x */ > + icssg0_iep0: iep@2e000 { > + compatible = "ti,am654-icss-iep"; > + reg = <0x2e000 0x1000>; > + clocks = <&icssg0_iepclk_mux>; > + }; Choose one example. Best regards, Krzysztof
Hi Krzysztof, On 24/08/23 12:13 pm, Krzysztof Kozlowski wrote: > On 23/08/2023 13:32, MD Danish Anwar wrote: >> Add a DT binding document for the ICSS Industrial Ethernet Peripheral(IEP) >> hardware. IEP supports packet timestamping, PTP and PPS. >> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Really? Where? Conor gave his RB tag for patch 1 and 2 in v4 https://lore.kernel.org/all/20230814-quarters-cahoots-1fbd583baad9@spud/ > >> Reviewed-by: Roger Quadros <rogerq@kernel.org> > > Now you are making things up. Please stop faking tags. Roger provided his RB tag in v5 for all the patches https://lore.kernel.org/all/5d077342-435f-2829-ba2a-cdf763b6b8e1@kernel.org/ > >> Reviewed-by: Simon Horman <horms@kernel.org> > > Where? > Simon gave his RB tag for all the patches of this series in v5 https://lore.kernel.org/all/ZN9aSTUOT+SKESQS@vergenet.net/ >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> >> --- >> .../devicetree/bindings/net/ti,icss-iep.yaml | 61 +++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> new file mode 100644 >> index 000000000000..75668bea8614 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> @@ -0,0 +1,61 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >> + >> +maintainers: >> + - Md Danish Anwar <danishanwar@ti.com> >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - ti,am642-icss-iep >> + - ti,j721e-icss-iep >> + - const: ti,am654-icss-iep >> + >> + - const: ti,am654-icss-iep >> + >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + description: phandle to the IEP source clock >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + > > Drop stray blank line > >> + /* AM65x */ >> + icssg0_iep0: iep@2e000 { >> + compatible = "ti,am654-icss-iep"; >> + reg = <0x2e000 0x1000>; >> + clocks = <&icssg0_iepclk_mux>; >> + }; > > Choose one example. > > > Best regards, > Krzysztof >
On 24/08/2023 08:47, Md Danish Anwar wrote: > Hi Krzysztof, > > On 24/08/23 12:13 pm, Krzysztof Kozlowski wrote: >> On 23/08/2023 13:32, MD Danish Anwar wrote: >>> Add a DT binding document for the ICSS Industrial Ethernet Peripheral(IEP) >>> hardware. IEP supports packet timestamping, PTP and PPS. >>> >>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >> >> Really? Where? > > Conor gave his RB tag for patch 1 and 2 in v4 > https://lore.kernel.org/all/20230814-quarters-cahoots-1fbd583baad9@spud/ OK, My mistake, cover letter was not the place where I was looking for Conor's reviews... >> >>> Reviewed-by: Roger Quadros <rogerq@kernel.org> >> >> Now you are making things up. Please stop faking tags. > > Roger provided his RB tag in v5 for all the patches > https://lore.kernel.org/all/5d077342-435f-2829-ba2a-cdf763b6b8e1@kernel.org/ >> >>> Reviewed-by: Simon Horman <horms@kernel.org> >> >> Where? >> > > Simon gave his RB tag for all the patches of this series in v5 > https://lore.kernel.org/all/ZN9aSTUOT+SKESQS@vergenet.net/ OK, I still question though reviewing own code. Best regards, Krzysztof
On 24/08/23 12:13 pm, Krzysztof Kozlowski wrote: > On 23/08/2023 13:32, MD Danish Anwar wrote: >> Add a DT binding document for the ICSS Industrial Ethernet Peripheral(IEP) >> hardware. IEP supports packet timestamping, PTP and PPS. >> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Really? Where? > >> Reviewed-by: Roger Quadros <rogerq@kernel.org> > > Now you are making things up. Please stop faking tags. > >> Reviewed-by: Simon Horman <horms@kernel.org> > > Where? > >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> >> --- >> .../devicetree/bindings/net/ti,icss-iep.yaml | 61 +++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> new file mode 100644 >> index 000000000000..75668bea8614 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> @@ -0,0 +1,61 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >> + >> +maintainers: >> + - Md Danish Anwar <danishanwar@ti.com> >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - ti,am642-icss-iep >> + - ti,j721e-icss-iep >> + - const: ti,am654-icss-iep >> + >> + - const: ti,am654-icss-iep >> + >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + description: phandle to the IEP source clock >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + > > Drop stray blank line > I will drop this blank line. >> + /* AM65x */ >> + icssg0_iep0: iep@2e000 { >> + compatible = "ti,am654-icss-iep"; >> + reg = <0x2e000 0x1000>; >> + clocks = <&icssg0_iepclk_mux>; >> + }; > > Choose one example. > I will only keep one example (AM65x) and drop other examples. > > Best regards, > Krzysztof > I will make above changes and remove Roger's RB from patch 3 and 4 as he is the author of those patches. With these changes I will send next revision today. If there is anything else, please let me know.
diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml new file mode 100644 index 000000000000..75668bea8614 --- /dev/null +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module + +maintainers: + - Md Danish Anwar <danishanwar@ti.com> + +properties: + compatible: + oneOf: + - items: + - enum: + - ti,am642-icss-iep + - ti,j721e-icss-iep + - const: ti,am654-icss-iep + + - const: ti,am654-icss-iep + + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + description: phandle to the IEP source clock + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + + /* AM65x */ + icssg0_iep0: iep@2e000 { + compatible = "ti,am654-icss-iep"; + reg = <0x2e000 0x1000>; + clocks = <&icssg0_iepclk_mux>; + }; + + /* J721E */ + icssg0_iep1: iep@2f000 { + compatible = "ti,j721e-icss-iep","ti,am654-icss-iep"; + reg = <0x2e000 0x1000>; + clocks = <&icssg0_iepclk_mux>; + }; + + + /* AM64x */ + icssg0_iep2: iep@2b000 { + compatible = "ti,am642-icss-iep", "ti,am654-icss-iep"; + reg = <0x2e000 0x1000>; + clocks = <&icssg0_iepclk_mux>; + };