| Message ID | 20230816022323.1921907-1-chenjiahao16@huawei.com |
|---|---|
| State | Accepted |
| Commit | 16fae979ed6b2753c07bdc9943cd9892349b69d4 |
| Headers | show |
| Series | [-next] media: usb: siano: Use kmemdup to simplify kmalloc and memcpy logic | expand |
diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/smsusb.c index 8a39cac76c58..9d9e14c858e6 100644 --- a/drivers/media/usb/siano/smsusb.c +++ b/drivers/media/usb/siano/smsusb.c @@ -279,10 +279,8 @@ static int smsusb1_load_firmware(struct usb_device *udev, int id, int board_id) } } - fw_buffer = kmalloc(fw->size, GFP_KERNEL); + fw_buffer = kmemdup(fw->data, fw->size, GFP_KERNEL); if (fw_buffer) { - memcpy(fw_buffer, fw->data, fw->size); - rc = usb_bulk_msg(udev, usb_sndbulkpipe(udev, 2), fw_buffer, fw->size, &dummy, 1000);
Using kmemdup() helper function rather than implementing it again with kmalloc() + memcpy(), which improves the code readability. Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com> --- drivers/media/usb/siano/smsusb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)