[3/9] smartpqi: refactor rename MACRO to clarify purpose

Message ID	20230817131232.86754-4-don.brace@microchip.com
State	Superseded
Headers	show Return-Path: <linux-scsi-owner@vger.kernel.org> From: Don Brace <don.brace@microchip.com> To: <don.brace@microchip.com>, <Kevin.Barnett@microchip.com>, <scott.teel@microchip.com>, <Justin.Lindley@microchip.com>, <scott.benesh@microchip.com>, <gerry.morong@microchip.com>, <mahesh.rajashekhara@microchip.com>, <mike.mcgowen@microchip.com>, <murthy.bhat@microchip.com>, <kumar.meiyappan@microchip.com>, <jeremy.reeves@microchip.com>, <david.strahan@microchip.com>, <hch@infradead.org>, <jejb@linux.vnet.ibm.com>, <joseph.szczypek@hpe.com>, <POSWALD@suse.com> CC: <linux-scsi@vger.kernel.org> Subject: [PATCH 3/9] smartpqi: refactor rename MACRO to clarify purpose Date: Thu, 17 Aug 2023 08:12:26 -0500 Message-ID: <20230817131232.86754-4-don.brace@microchip.com> In-Reply-To: <20230817131232.86754-1-don.brace@microchip.com> References: <20230817131232.86754-1-don.brace@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk
Series	smartpqi updates \| expand [0/9] smartpqi updates [1/9] smartpqi: reformat to align with oob driver [2/9] smartpqi: add abort handler [3/9] smartpqi: refactor rename MACRO to clarify purpose [4/9] smartpqi: refactor rename pciinfo to pci_info [5/9] smartpqi: simplify lun_number assignment [6/9] smartpqi: enhance shutdown notification [7/9] smartpqi: enhance controller offline notification [8/9] smartpqi: enhance error messages [9/9] smartpqi: change driver version to 2.1.24-046

Message ID

20230817131232.86754-4-don.brace@microchip.com

State

Superseded

Headers

From: Don Brace <don.brace@microchip.com>
To: <don.brace@microchip.com>, <Kevin.Barnett@microchip.com>,
        <scott.teel@microchip.com>, <Justin.Lindley@microchip.com>,
        <scott.benesh@microchip.com>, <gerry.morong@microchip.com>,
        <mahesh.rajashekhara@microchip.com>, <mike.mcgowen@microchip.com>,
        <murthy.bhat@microchip.com>, <kumar.meiyappan@microchip.com>,
        <jeremy.reeves@microchip.com>, <david.strahan@microchip.com>,
        <hch@infradead.org>, <jejb@linux.vnet.ibm.com>,
        <joseph.szczypek@hpe.com>, <POSWALD@suse.com>
CC: <linux-scsi@vger.kernel.org>
Subject: [PATCH 3/9] smartpqi: refactor rename MACRO to clarify purpose
Date: Thu, 17 Aug 2023 08:12:26 -0500
Message-ID: <20230817131232.86754-4-don.brace@microchip.com>
In-Reply-To: <20230817131232.86754-1-don.brace@microchip.com>
References: <20230817131232.86754-1-don.brace@microchip.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

Series

smartpqi updates | expand

Commit Message

Don Brace Aug. 17, 2023, 1:12 p.m. UTC

From: Kevin Barnett <kevin.barnett@microchip.com>

Rename SOP_RC_INCORRECT_LOGICAL_UNIT to SOP_TMF_INCORRECT_LOGICAL_UNIT
to clarify the intended purpose.

Reviewed-by: Mahesh Rajashekhara <mahesh.rajashekhara@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
Signed-off-by: Kevin Barnett <kevin.barnett@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 drivers/scsi/smartpqi/smartpqi.h      | 2 +-
 drivers/scsi/smartpqi/smartpqi_init.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi/smartpqi.h
index e560d99efa95..041940183516 100644
--- a/drivers/scsi/smartpqi/smartpqi.h
+++ b/drivers/scsi/smartpqi/smartpqi.h
@@ -710,7 +710,7 @@  typedef u32 pqi_index_t;
 #define SOP_TMF_COMPLETE		0x0
 #define SOP_TMF_REJECTED		0x4
 #define SOP_TMF_FUNCTION_SUCCEEDED	0x8
-#define SOP_RC_INCORRECT_LOGICAL_UNIT	0x9
+#define SOP_TMF_INCORRECT_LOGICAL_UNIT	0x9
 
 /* additional CDB bytes usage field codes */
 #define SOP_ADDITIONAL_CDB_BYTES_0	0	/* 16-byte CDB */
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index ec36896eb08e..2d695e7cd83f 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -3308,7 +3308,7 @@  static int pqi_interpret_task_management_response(struct pqi_ctrl_info *ctrl_inf
 	case SOP_TMF_REJECTED:
 		rc = -EAGAIN;
 		break;
-	case SOP_RC_INCORRECT_LOGICAL_UNIT:
+	case SOP_TMF_INCORRECT_LOGICAL_UNIT:
 		rc = -ENODEV;
 		break;
 	default:

[3/9] smartpqi: refactor rename MACRO to clarify purpose

Commit Message

Patch