| Message ID | 20230811154247.481194-1-ezulian@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] rt-tests: cyclictest: Remove warnings due different signedness in comparison | expand |
On Fri, 11 Aug 2023, Eder Zulian wrote: > Type casting used to remove compiler warnings due to comparison of > integer expressions of different signedness. > > Signed-off-by: Eder Zulian <ezulian@redhat.com> > --- > v2: Cleaned up coding style and addressed review comments > > src/cyclictest/cyclictest.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c > index 4a7108e..179ae8b 100644 > --- a/src/cyclictest/cyclictest.c > +++ b/src/cyclictest/cyclictest.c > @@ -317,8 +317,10 @@ static int raise_soft_prio(int policy, const struct sched_param *param) > return err; > } > > - soft_max = (rlim.rlim_cur == RLIM_INFINITY) ? policy_max : rlim.rlim_cur; > - hard_max = (rlim.rlim_max == RLIM_INFINITY) ? policy_max : rlim.rlim_max; > + soft_max = (rlim.rlim_cur == RLIM_INFINITY) ? (unsigned int)policy_max > + : rlim.rlim_cur; > + hard_max = (rlim.rlim_max == RLIM_INFINITY) ? (unsigned int)policy_max > + : rlim.rlim_max; > > if (prio > soft_max && prio <= hard_max) { > rlim.rlim_cur = prio; > -- > 2.39.3 > > Signed-off-by: John Kacur <jkacur@redhat.com>
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c index 4a7108e..179ae8b 100644 --- a/src/cyclictest/cyclictest.c +++ b/src/cyclictest/cyclictest.c @@ -317,8 +317,10 @@ static int raise_soft_prio(int policy, const struct sched_param *param) return err; } - soft_max = (rlim.rlim_cur == RLIM_INFINITY) ? policy_max : rlim.rlim_cur; - hard_max = (rlim.rlim_max == RLIM_INFINITY) ? policy_max : rlim.rlim_max; + soft_max = (rlim.rlim_cur == RLIM_INFINITY) ? (unsigned int)policy_max + : rlim.rlim_cur; + hard_max = (rlim.rlim_max == RLIM_INFINITY) ? (unsigned int)policy_max + : rlim.rlim_max; if (prio > soft_max && prio <= hard_max) { rlim.rlim_cur = prio;
Type casting used to remove compiler warnings due to comparison of integer expressions of different signedness. Signed-off-by: Eder Zulian <ezulian@redhat.com> --- v2: Cleaned up coding style and addressed review comments src/cyclictest/cyclictest.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)