diff mbox series

bus: mhi: host: remove unused-but-set parameter

Message ID 20230811134547.3231160-1-arnd@kernel.org
State New
Headers show
Series bus: mhi: host: remove unused-but-set parameter | expand

Commit Message

Arnd Bergmann Aug. 11, 2023, 1:45 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Clang warns about a parameter that is decremented but never evaluated heere:

bus/mhi/host/main.c:803:13: error: parameter 'event_quota' set but not used [-Werror,-Wunused-but-set-parameter]
                             u32 event_quota)

Remove the access to the variable to avoid that warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/bus/mhi/host/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jeffrey Hugo Aug. 11, 2023, 1:51 p.m. UTC | #1 
On 8/11/2023 7:45 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Clang warns about a parameter that is decremented but never evaluated heere:
> 
> bus/mhi/host/main.c:803:13: error: parameter 'event_quota' set but not used [-Werror,-Wunused-but-set-parameter]
>                               u32 event_quota)
> 
> Remove the access to the variable to avoid that warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Manivannan Sadhasivam Aug. 11, 2023, 3:06 p.m. UTC | #2 
On Fri, Aug 11, 2023 at 03:45:41PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Clang warns about a parameter that is decremented but never evaluated heere:
> 
> bus/mhi/host/main.c:803:13: error: parameter 'event_quota' set but not used [-Werror,-Wunused-but-set-parameter]
>                              u32 event_quota)
> 
> Remove the access to the variable to avoid that warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to mhi-next!

- Mani

> ---
>  drivers/bus/mhi/host/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> index 74a75439c7130..dcf627b36e829 100644
> --- a/drivers/bus/mhi/host/main.c
> +++ b/drivers/bus/mhi/host/main.c
> @@ -938,7 +938,6 @@ int mhi_process_ctrl_ev_ring(struct mhi_controller *mhi_cntrl,
>  				if (!mhi_chan->configured)
>  					break;
>  				parse_xfer_event(mhi_cntrl, local_rp, mhi_chan);
> -				event_quota--;
>  			}
>  			break;
>  		default:
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
index 74a75439c7130..dcf627b36e829 100644
--- a/drivers/bus/mhi/host/main.c
+++ b/drivers/bus/mhi/host/main.c
@@ -938,7 +938,6 @@  int mhi_process_ctrl_ev_ring(struct mhi_controller *mhi_cntrl,
 				if (!mhi_chan->configured)
 					break;
 				parse_xfer_event(mhi_cntrl, local_rp, mhi_chan);
-				event_quota--;
 			}
 			break;
 		default: