| Message ID | 20230807023206.2128846-1-william.xuanziyang@huawei.com |
|---|---|
| State | Accepted |
| Commit | 3cd43dd15f9dbfb67a60889992bf03b92370b202 |
| Headers | show |
| Series | Bluetooth: Remove unnecessary NULL check before vfree() | expand |
diff --git a/net/bluetooth/coredump.c b/net/bluetooth/coredump.c index d2d2624ec708..ec97a4bab1c9 100644 --- a/net/bluetooth/coredump.c +++ b/net/bluetooth/coredump.c @@ -100,8 +100,7 @@ void hci_devcd_reset(struct hci_dev *hdev) /* Call with hci_dev_lock only. */ static void hci_devcd_free(struct hci_dev *hdev) { - if (hdev->dump.head) - vfree(hdev->dump.head); + vfree(hdev->dump.head); hci_devcd_reset(hdev); }
Get a coccinelle warning as follows: net/bluetooth/coredump.c:104:2-7: WARNING: NULL check before some freeing functions is not needed. Remove the unnecessary NULL check. Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> --- net/bluetooth/coredump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)