diff mbox series

tty: n_gsm: require CAP_NET_ADMIN to attach N_GSM0710 ldisc

Message ID 20230731185942.279611-1-cascardo@canonical.com
State New
Headers show
Series tty: n_gsm: require CAP_NET_ADMIN to attach N_GSM0710 ldisc | expand

Commit Message

Thadeu Lima de Souza Cascardo July 31, 2023, 6:59 p.m. UTC 
Any unprivileged user can attach N_GSM0710 ldisc, but it requires
CAP_NET_ADMIN to create a GSM network anyway.

Require initial namespace CAP_NET_ADMIN to do that.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
 drivers/tty/n_gsm.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 1cdefac4dd1b..c7a787f10a9c 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -3576,6 +3576,9 @@  static int gsmld_open(struct tty_struct *tty)
 {
 	struct gsm_mux *gsm;
 
+	if (!capable(CAP_NET_ADMIN))
+		return -EPERM;
+
 	if (tty->ops->write == NULL)
 		return -EINVAL;