diff mbox series

[-next] mmc: sdhci-st: Use devm_platform_ioremap_resource_byname()

Message ID 20230802094028.976612-1-lizetao1@huawei.com
State New
Headers show
Series [-next] mmc: sdhci-st: Use devm_platform_ioremap_resource_byname() | expand

Commit Message

Li Zetao Aug. 2, 2023, 9:40 a.m. UTC
Convert platform_get_resource_byname() + devm_ioremap_resource() to a
single call to devm_platform_ioremap_resource_byname(), as this is
exactly what this function does.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
 drivers/mmc/host/sdhci-st.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Adrian Hunter Aug. 3, 2023, 5:37 a.m. UTC | #1
On 2/08/23 12:40, Li Zetao wrote:
> Convert platform_get_resource_byname() + devm_ioremap_resource() to a
> single call to devm_platform_ioremap_resource_byname(), as this is
> exactly what this function does.
> 
> Signed-off-by: Li Zetao <lizetao1@huawei.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-st.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 6415916fbd91..97f350953c4b 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -348,7 +348,6 @@ static int sdhci_st_probe(struct platform_device *pdev)
>  	struct clk *clk, *icnclk;
>  	int ret = 0;
>  	u16 host_version;
> -	struct resource *res;
>  	struct reset_control *rstc;
>  
>  	clk =  devm_clk_get(&pdev->dev, "mmc");
> @@ -397,9 +396,7 @@ static int sdhci_st_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Configure the FlashSS Top registers for setting eMMC TX/RX delay */
> -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -					   "top-mmc-delay");
> -	pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> +	pdata->top_ioaddr = devm_platform_ioremap_resource_byname(pdev, "top-mmc-delay");
>  	if (IS_ERR(pdata->top_ioaddr))
>  		pdata->top_ioaddr = NULL;
>
Ulf Hansson Aug. 8, 2023, 10:52 a.m. UTC | #2
On Wed, 2 Aug 2023 at 11:41, Li Zetao <lizetao1@huawei.com> wrote:
>
> Convert platform_get_resource_byname() + devm_ioremap_resource() to a
> single call to devm_platform_ioremap_resource_byname(), as this is
> exactly what this function does.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-st.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 6415916fbd91..97f350953c4b 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -348,7 +348,6 @@ static int sdhci_st_probe(struct platform_device *pdev)
>         struct clk *clk, *icnclk;
>         int ret = 0;
>         u16 host_version;
> -       struct resource *res;
>         struct reset_control *rstc;
>
>         clk =  devm_clk_get(&pdev->dev, "mmc");
> @@ -397,9 +396,7 @@ static int sdhci_st_probe(struct platform_device *pdev)
>         }
>
>         /* Configure the FlashSS Top registers for setting eMMC TX/RX delay */
> -       res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -                                          "top-mmc-delay");
> -       pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> +       pdata->top_ioaddr = devm_platform_ioremap_resource_byname(pdev, "top-mmc-delay");
>         if (IS_ERR(pdata->top_ioaddr))
>                 pdata->top_ioaddr = NULL;
>
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index 6415916fbd91..97f350953c4b 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -348,7 +348,6 @@  static int sdhci_st_probe(struct platform_device *pdev)
 	struct clk *clk, *icnclk;
 	int ret = 0;
 	u16 host_version;
-	struct resource *res;
 	struct reset_control *rstc;
 
 	clk =  devm_clk_get(&pdev->dev, "mmc");
@@ -397,9 +396,7 @@  static int sdhci_st_probe(struct platform_device *pdev)
 	}
 
 	/* Configure the FlashSS Top registers for setting eMMC TX/RX delay */
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-					   "top-mmc-delay");
-	pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
+	pdata->top_ioaddr = devm_platform_ioremap_resource_byname(pdev, "top-mmc-delay");
 	if (IS_ERR(pdata->top_ioaddr))
 		pdata->top_ioaddr = NULL;