| Message ID | 20230801154451.3505492-1-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/m68k: Add URL to semihosting spec | expand |
On Tue, 1 Aug 2023 at 16:44, Peter Maydell <peter.maydell@linaro.org> wrote: > > The spec for m68k semihosting is documented in the libgloss > sources. Add a comment with the URL for it, as we already > have for nios2 semihosting. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/m68k/m68k-semi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c > index 239f6e44e90..80cd8d70dbb 100644 > --- a/target/m68k/m68k-semi.c > +++ b/target/m68k/m68k-semi.c > @@ -15,6 +15,10 @@ > * > * You should have received a copy of the GNU General Public License > * along with this program; if not, see <http://www.gnu.org/licenses/>. > + * > + * The semihosting protocol implemented here is described in the > + * libgloss sources: > + * https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;hb=HEAD > */ > > #include "qemu/osdep.h" > -- Ping for review? I can take this through the arm tree if you don't have an m68k pullreq planned. thanks -- PMM
On 8/1/23 08:44, Peter Maydell wrote: > The spec for m68k semihosting is documented in the libgloss > sources. Add a comment with the URL for it, as we already > have for nios2 semihosting. > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > --- > target/m68k/m68k-semi.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Peter Maydell <peter.maydell@linaro.org> writes: > The spec for m68k semihosting is documented in the libgloss > sources. Add a comment with the URL for it, as we already > have for nios2 semihosting. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/m68k/m68k-semi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c > index 239f6e44e90..80cd8d70dbb 100644 > --- a/target/m68k/m68k-semi.c > +++ b/target/m68k/m68k-semi.c > @@ -15,6 +15,10 @@ > * > * You should have received a copy of the GNU General Public License > * along with this program; if not, see <http://www.gnu.org/licenses/>. > + * > + * The semihosting protocol implemented here is described in the > + * libgloss sources: > + * https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;hb=HEAD > */ > > #include "qemu/osdep.h" Matches what we reference in emulation.rst so: Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
On 1/8/23 17:44, Peter Maydell wrote: > The spec for m68k semihosting is documented in the libgloss > sources. Add a comment with the URL for it, as we already > have for nios2 semihosting. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/m68k/m68k-semi.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Tue, 29 Aug 2023 at 16:48, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Tue, 1 Aug 2023 at 16:44, Peter Maydell <peter.maydell@linaro.org> wrote: > > > > The spec for m68k semihosting is documented in the libgloss > > sources. Add a comment with the URL for it, as we already > > have for nios2 semihosting. > > > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > > --- > > target/m68k/m68k-semi.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c > > index 239f6e44e90..80cd8d70dbb 100644 > > --- a/target/m68k/m68k-semi.c > > +++ b/target/m68k/m68k-semi.c > > @@ -15,6 +15,10 @@ > > * > > * You should have received a copy of the GNU General Public License > > * along with this program; if not, see <http://www.gnu.org/licenses/>. > > + * > > + * The semihosting protocol implemented here is described in the > > + * libgloss sources: > > + * https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;hb=HEAD > > */ > > > > #include "qemu/osdep.h" > > -- > > Ping for review? I can take this through the arm tree if > you don't have an m68k pullreq planned. Picked up for target-arm.next. -- PMM
diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c index 239f6e44e90..80cd8d70dbb 100644 --- a/target/m68k/m68k-semi.c +++ b/target/m68k/m68k-semi.c @@ -15,6 +15,10 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, see <http://www.gnu.org/licenses/>. + * + * The semihosting protocol implemented here is described in the + * libgloss sources: + * https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=libgloss/m68k/m68k-semi.txt;hb=HEAD */ #include "qemu/osdep.h"
The spec for m68k semihosting is documented in the libgloss sources. Add a comment with the URL for it, as we already have for nios2 semihosting. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/m68k/m68k-semi.c | 4 ++++ 1 file changed, 4 insertions(+)