| Message ID | 20230728014702.25775-1-duke_xinanwen@163.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | bus: mhi: host: pci_generic: Add support for Lenovo RM520N-GL | expand |
On Thu, Jul 27, 2023 at 06:47:02PM -0700, Duke Xin(辛安文) wrote: It is a Quectel modem, right? Then it should be mentioned as Quectel in subject. > This modem is designed based on Qualcomm SDX6x and it will align with the quectel previous RM520N-GL modem settings. s/it will align/works s/quectel previous/Quectel's existing > But this one is designed for lenovo laptop usecase, hence Quectel got a new PID. > Also, wrap the commit message to 75 columns. And always run ./scripts/checkpatch.pl and fix warnings/errors before posting a patch. - Mani > Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com> > --- > drivers/bus/mhi/host/pci_generic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c > index fcd80bc92978..e4f2fb67dfaf 100644 > --- a/drivers/bus/mhi/host/pci_generic.c > +++ b/drivers/bus/mhi/host/pci_generic.c > @@ -604,6 +604,9 @@ static const struct pci_device_id mhi_pci_id_table[] = { > /* RM520N-GL (sdx6x), eSIM */ > { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1004), > .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info }, > + /* RM520N-GL (sdx6x), Lenovo variant */ > + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1007), > + .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info }, > { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d), /* EM160R-GL (sdx24) */ > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info }, > { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */ > -- > 2.25.1 >
Hi Mani
Thank you very much for your careful review and suggestions.
I will fixed it in patch V2 version.
辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
-----邮件原件-----
发件人: Manivannan Sadhasivam <mani@kernel.org>
发送时间: 2023年8月2日 19:08
收件人: Duke Xin(辛安文) <duke_xinanwen@163.com>
抄送: mani@kernel.org; loic.poulain@linaro.org; slark_xiao@163.com; fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@quectel.com>; Duke Xin(辛安文) <duke.xin@quectel.com>
主题: Re: [PATCH] bus: mhi: host: pci_generic: Add support for Lenovo RM520N-GL
On Thu, Jul 27, 2023 at 06:47:02PM -0700, Duke Xin(辛安文) wrote:
It is a Quectel modem, right? Then it should be mentioned as Quectel in subject.
> This modem is designed based on Qualcomm SDX6x and it will align with the quectel previous RM520N-GL modem settings.
s/it will align/works
s/quectel previous/Quectel's existing
> But this one is designed for lenovo laptop usecase, hence Quectel got a new PID.
>
Also, wrap the commit message to 75 columns. And always run ./scripts/checkpatch.pl and fix warnings/errors before posting a patch.
- Mani
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index fcd80bc92978..e4f2fb67dfaf 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -604,6 +604,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> /* RM520N-GL (sdx6x), eSIM */
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1004),
> .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
> + /* RM520N-GL (sdx6x), Lenovo variant */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1007),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL
> (sdx24) */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c index fcd80bc92978..e4f2fb67dfaf 100644 --- a/drivers/bus/mhi/host/pci_generic.c +++ b/drivers/bus/mhi/host/pci_generic.c @@ -604,6 +604,9 @@ static const struct pci_device_id mhi_pci_id_table[] = { /* RM520N-GL (sdx6x), eSIM */ { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1004), .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info }, + /* RM520N-GL (sdx6x), Lenovo variant */ + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1007), + .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info }, { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d), /* EM160R-GL (sdx24) */ .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info }, { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
This modem is designed based on Qualcomm SDX6x and it will align with the quectel previous RM520N-GL modem settings. But this one is designed for lenovo laptop usecase, hence Quectel got a new PID. Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com> --- drivers/bus/mhi/host/pci_generic.c | 3 +++ 1 file changed, 3 insertions(+)