diff mbox series

gpio: rc5t583: remove unneeded call to platform_set_drvdata()

Message ID 20230728182009.18445-1-aboutphysycs@gmail.com
State Accepted
Commit 8e85d6af1b3ceb619098c6b8a9f38e9e006e9c09
Headers show
Series gpio: rc5t583: remove unneeded call to platform_set_drvdata() | expand

Commit Message

Andrei Coardos July 28, 2023, 6:20 p.m. UTC 
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-rc5t583.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Bartosz Golaszewski Aug. 1, 2023, 7:27 p.m. UTC | #1 
On Fri, Jul 28, 2023 at 8:20 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/gpio/gpio-rc5t583.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c
> index 4fae3ebea790..c34dcadaee36 100644
> --- a/drivers/gpio/gpio-rc5t583.c
> +++ b/drivers/gpio/gpio-rc5t583.c
> @@ -121,8 +121,6 @@ static int rc5t583_gpio_probe(struct platform_device *pdev)
>         if (pdata && pdata->gpio_base)
>                 rc5t583_gpio->gpio_chip.base = pdata->gpio_base;
>
> -       platform_set_drvdata(pdev, rc5t583_gpio);
> -
>         return devm_gpiochip_add_data(&pdev->dev, &rc5t583_gpio->gpio_chip,
>                                       rc5t583_gpio);
>  }
> --
> 2.34.1
>

Applied, thanks!

Bartosz
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c
index 4fae3ebea790..c34dcadaee36 100644
--- a/drivers/gpio/gpio-rc5t583.c
+++ b/drivers/gpio/gpio-rc5t583.c
@@ -121,8 +121,6 @@  static int rc5t583_gpio_probe(struct platform_device *pdev)
 	if (pdata && pdata->gpio_base)
 		rc5t583_gpio->gpio_chip.base = pdata->gpio_base;
 
-	platform_set_drvdata(pdev, rc5t583_gpio);
-
 	return devm_gpiochip_add_data(&pdev->dev, &rc5t583_gpio->gpio_chip,
 				      rc5t583_gpio);
 }