| Message ID | 1466777466-21306-2-git-send-email-yingjoe.chen@mediatek.com |
|---|---|
| State | New |
| Headers | show |
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 19b270b..b3f1fda 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2689,6 +2689,13 @@ sub process { "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); } +# discourage the use of default n + if ($realfile =~ /Kconfig/ && + $line =~ /^\+\s*default\s*n$/i) { + WARN("CONFIG_DEFAULT_N", + "Use of default n is unnecessary, default is n when omitted.\n" . $herecurr); + } + if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { my $flag = $1;
If a Kconfig config option doesn't specify 'default', the default will be n. Adding 'default n' is unnecessary. Add a test to warn about this. Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> --- scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+) -- 1.9.1