| Message ID | 20230728191423.13837-1-patrick.whewell@sightlineapplications.com |
|---|---|
| State | Accepted |
| Commit | 783cb693828ce487cf0bc6ad16cbcf2caae6f8d9 |
| Headers | show |
| Series | clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src | expand |
On 28/07/2023 20:14, Patrick Whewell wrote: > Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg > didn't update its configuration" error. > > Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com> > Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250") > --- > drivers/clk/qcom/gcc-sm8250.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c > index b6cf4bc88d4d..d3c75bb55946 100644 > --- a/drivers/clk/qcom/gcc-sm8250.c > +++ b/drivers/clk/qcom/gcc-sm8250.c > @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > .name = "gcc_sdcc2_apps_clk_src", > .parent_data = gcc_parent_data_4, > .num_parents = ARRAY_SIZE(gcc_parent_data_4), > + .flags = CLK_OPS_PARENT_ENABLE, > .ops = &clk_rcg2_floor_ops, > }, > }; Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Fri, Jul 28, 2023 at 12:14:23PM -0700, Patrick Whewell wrote: > Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg > didn't update its configuration" error. > > Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com> > Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250") The error appears resolved when tested on my Open-Q 865 SOM. Tested-by: William Breathitt Gray <william.gray@linaro.org> > --- > drivers/clk/qcom/gcc-sm8250.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c > index b6cf4bc88d4d..d3c75bb55946 100644 > --- a/drivers/clk/qcom/gcc-sm8250.c > +++ b/drivers/clk/qcom/gcc-sm8250.c > @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > .name = "gcc_sdcc2_apps_clk_src", > .parent_data = gcc_parent_data_4, > .num_parents = ARRAY_SIZE(gcc_parent_data_4), > + .flags = CLK_OPS_PARENT_ENABLE, > .ops = &clk_rcg2_floor_ops, > }, > }; > -- > 2.25.1 >
On Friday, July 28, 2023 12:24 PM, Konrad Dybcio wrote: > On 28.07.2023 21:14, Patrick Whewell wrote: > > Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg > > didn't update its configuration" error. > > > > Signed-off-by: Patrick Whewell > > <patrick.whewell@sightlineapplications.com> > > Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller > > driver for SM8250") > > --- > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > You could also mention that the error is caused by GPLL9 (the one providing > the highest frequency in the freq table) not being on by default. > > And ultra nit: your s-o-b should go last I will be sending over v2 shortly with both comments addressed. > > Konrad > > drivers/clk/qcom/gcc-sm8250.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/qcom/gcc-sm8250.c > > b/drivers/clk/qcom/gcc-sm8250.c index b6cf4bc88d4d..d3c75bb55946 > > 100644 > > --- a/drivers/clk/qcom/gcc-sm8250.c > > +++ b/drivers/clk/qcom/gcc-sm8250.c > > @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > > .name = "gcc_sdcc2_apps_clk_src", > > .parent_data = gcc_parent_data_4, > > .num_parents = ARRAY_SIZE(gcc_parent_data_4), > > + .flags = CLK_OPS_PARENT_ENABLE, > > .ops = &clk_rcg2_floor_ops, > > }, > > };
diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c index b6cf4bc88d4d..d3c75bb55946 100644 --- a/drivers/clk/qcom/gcc-sm8250.c +++ b/drivers/clk/qcom/gcc-sm8250.c @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_4, .num_parents = ARRAY_SIZE(gcc_parent_data_4), + .flags = CLK_OPS_PARENT_ENABLE, .ops = &clk_rcg2_floor_ops, }, };
Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" error. Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com> Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250") --- drivers/clk/qcom/gcc-sm8250.c | 1 + 1 file changed, 1 insertion(+)