diff mbox series

gpio :lp3943 :remove unneeded platform_set_drvdata() call

Message ID 20230720095455.21474-1-aboutphysycs@gmail.com
State Superseded
Headers show
Series gpio :lp3943 :remove unneeded platform_set_drvdata() call | expand

Commit Message

Andrei Coardos July 20, 2023, 9:54 a.m. UTC 
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call, to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-lp3943.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andy Shevchenko July 21, 2023, 10:26 a.m. UTC | #1 
On Thu, Jul 20, 2023 at 12:54:55PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call, to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.

Is this a duplicate of previously sent the same?

Please, do correct versioning of the patches and changelogs being added.
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
index 79edd5db49d2..8e58242f5123 100644
--- a/drivers/gpio/gpio-lp3943.c
+++ b/drivers/gpio/gpio-lp3943.c
@@ -199,8 +199,6 @@  static int lp3943_gpio_probe(struct platform_device *pdev)
 	lp3943_gpio->chip = lp3943_gpio_chip;
 	lp3943_gpio->chip.parent = &pdev->dev;
 
-	platform_set_drvdata(pdev, lp3943_gpio);
-
 	return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
 				      lp3943_gpio);
 }