| Message ID | 20230721103124.18522-1-wangweiyang2@huawei.com |
|---|---|
| State | Accepted |
| Commit | 59ea9138c0753d7af19f9eba0ee29b8b55cecaf2 |
| Headers | show |
| Series | [-next] ALSA: seq: remove redundant unsigned comparison to zero | expand |
On Fri, 21 Jul 2023 12:31:24 +0200, Wang Weiyang wrote: > > Since struct snd_ump_block_info::first_group is unsigned char, comparison > to zero is redundant > > Signed-off-by: Wang Weiyang <wangweiyang2@huawei.com> Thanks, applied with a proper Fix tag now. Takashi
diff --git a/sound/core/seq/seq_ump_client.c b/sound/core/seq/seq_ump_client.c index fe21c801af74..f26a1812dfa7 100644 --- a/sound/core/seq/seq_ump_client.c +++ b/sound/core/seq/seq_ump_client.c @@ -298,8 +298,7 @@ static void update_group_attrs(struct seq_ump_client *client) } list_for_each_entry(fb, &client->ump->block_list, list) { - if (fb->info.first_group < 0 || - fb->info.first_group + fb->info.num_groups > SNDRV_UMP_MAX_GROUPS) + if (fb->info.first_group + fb->info.num_groups > SNDRV_UMP_MAX_GROUPS) break; group = &client->groups[fb->info.first_group]; for (i = 0; i < fb->info.num_groups; i++, group++) {
Since struct snd_ump_block_info::first_group is unsigned char, comparison to zero is redundant Signed-off-by: Wang Weiyang <wangweiyang2@huawei.com> --- sound/core/seq/seq_ump_client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)