| Message ID | 20230720074846.20350-3-quic_harihk@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add initial support for RDP415 of IPQ5018 family | expand |
On 7/20/2023 2:26 PM, Krzysztof Kozlowski wrote: > On 20/07/2023 09:48, Hariharan K wrote: >> Add the initial device tree support for the Reference Design >> Platform(RDP) 415 based on IPQ5018 family of SoC. This patch >> carries the support for Console UART and eMMC. >> >> Signed-off-by: Hariharan K <quic_harihk@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts | 49 +++++++++++++++++++++ >> 2 files changed, 50 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 6334e552b7c1..53df7f24488a 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8039-t2.dtb >> dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb >> dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb >> dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp415.dtb >> dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp432-c2.dtb >> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp441.dtb >> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp442.dtb >> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts >> new file mode 100644 >> index 000000000000..5c4b43f76a48 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts >> @@ -0,0 +1,49 @@ >> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause >> +/* >> + * IPQ5018 MP03.3-C2 board device tree source >> + * Copyright (c) 2023, The Linux Foundation. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include "ipq5018-rdp-common.dtsi" > > I don't understand this. You just added in in the same moment in > different patchset, so why creating this fake dependency? > > It makes review difficult, applying even more. > > Please organize your patches in some logical work. Sure, got it. Will rework this series and post v2. Best regards, Hariharan K > > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 6334e552b7c1..53df7f24488a 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8039-t2.dtb dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb +dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp415.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp432-c2.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp441.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp442.dtb diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts new file mode 100644 index 000000000000..5c4b43f76a48 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts @@ -0,0 +1,49 @@ +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause +/* + * IPQ5018 MP03.3-C2 board device tree source + * Copyright (c) 2023, The Linux Foundation. All rights reserved. + */ + +/dts-v1/; + +#include "ipq5018-rdp-common.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. IPQ5018/AP-MP03.3-C2"; + compatible = "qcom,ipq5018-ap-mp03.3-c2", "qcom,ipq5018"; +}; + +&sdhc_1 { + pinctrl-0 = <&sdc_default_state>; + pinctrl-names = "default"; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + max-frequency = <192000000>; + bus-width = <4>; + status = "okay"; +}; + +&tlmm { + sdc_default_state: sdc-default-state { + clk-pins { + pins = "gpio9"; + function = "sdc1_clk"; + drive-strength = <8>; + bias-disable; + }; + + cmd-pins { + pins = "gpio8"; + function = "sdc1_cmd"; + drive-strength = <8>; + bias-pull-up; + }; + + data-pins { + pins = "gpio4", "gpio5", "gpio6", "gpio7"; + function = "sdc1_data"; + drive-strength = <8>; + bias-disable; + }; + }; +};
Add the initial device tree support for the Reference Design Platform(RDP) 415 based on IPQ5018 family of SoC. This patch carries the support for Console UART and eMMC. Signed-off-by: Hariharan K <quic_harihk@quicinc.com> --- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts | 49 +++++++++++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts