diff mbox series

[2/4] arm64: dts: qcom: sc8180x-pmics: add missing gpio-ranges

Message ID 20230720083500.73554-2-krzysztof.kozlowski@linaro.org
State Accepted
Commit 565951b1202e1984154abaae4567f16f8073fca3
Headers show
Series [1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks | expand

Commit Message

Krzysztof Kozlowski July 20, 2023, 8:34 a.m. UTC 
The GPIO children of PMICs should use gpio-ranges:

  sc8180x-primus.dtb: pmic@0: gpio@c000: 'gpio-ranges' is a required property

Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Konrad Dybcio July 20, 2023, 8:37 a.m. UTC | #1 
On 20.07.2023 10:34, Krzysztof Kozlowski wrote:
> The GPIO children of PMICs should use gpio-ranges:
> 
>   sc8180x-primus.dtb: pmic@0: gpio@c000: 'gpio-ranges' is a required property
> 
> Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
index ef2f8b732833..53b283e29407 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
@@ -145,6 +145,7 @@  pmc8180_gpios: gpio@c000 {
 			compatible = "qcom,pmc8180-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pmc8180_gpios 0 0 10>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
@@ -303,6 +304,7 @@  pmc8180c_gpios: gpio@c000 {
 			compatible = "qcom,pmc8180c-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pmc8180c_gpios 0 0 12>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;