| Message ID | 20230720153038.1587196-1-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [for-8.1] scripts/git-submodule.sh: Don't rely on non-POSIX 'read' behaviour | expand |
On Thu, Jul 20, 2023 at 04:30:38PM +0100, Peter Maydell wrote: > The POSIX definition of the 'read' utility requires that you > specify the variable name to set; omitting the name and > having it default to 'REPLY' is a bashism. If your system > sh is dash, then it will print an error message during build: > > qemu/pc-bios/s390-ccw/../../scripts/git-submodule.sh: 106: read: arg count > > Specify the variable name explicitly. > > Fixes: fdb8fd8cb915647b ("git-submodule: allow partial update of .git-submodule-status") > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > scripts/git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
On 20/7/23 17:30, Peter Maydell wrote: > The POSIX definition of the 'read' utility requires that you > specify the variable name to set; omitting the name and > having it default to 'REPLY' is a bashism. If your system > sh is dash, then it will print an error message during build: > > qemu/pc-bios/s390-ccw/../../scripts/git-submodule.sh: 106: read: arg count > > Specify the variable name explicitly. > > Fixes: fdb8fd8cb915647b ("git-submodule: allow partial update of .git-submodule-status") > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > scripts/git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index 335f7f5fdf8..bb1222c7727 100755 --- a/scripts/git-submodule.sh +++ b/scripts/git-submodule.sh @@ -103,7 +103,7 @@ update) check_updated $module || echo Updated "$module" done - (while read -r; do + (while read -r REPLY; do for module in $modules; do case $REPLY in *" $module "*) continue 2 ;;
The POSIX definition of the 'read' utility requires that you specify the variable name to set; omitting the name and having it default to 'REPLY' is a bashism. If your system sh is dash, then it will print an error message during build: qemu/pc-bios/s390-ccw/../../scripts/git-submodule.sh: 106: read: arg count Specify the variable name explicitly. Fixes: fdb8fd8cb915647b ("git-submodule: allow partial update of .git-submodule-status") Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- scripts/git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)