| Message ID | 20230718105213.1275-2-henning.schild@siemens.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | platform/x86: move simatic ipc drivers into subdir | expand |
On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote: > If a user did choose to enable Siemens Simatic platform support they > likely want that driver to be enabled without having to flip more config > switches. So we make the watchdog driver config switch default to the > platform driver switches value. A nit-pick below. ... > config SIEMENS_SIMATIC_IPC_WDT > tristate "Siemens Simatic IPC Watchdog" > depends on SIEMENS_SIMATIC_IPC > + default SIEMENS_SIMATIC_IPC It's more natural to group tristate and default, vs. depends and select. > select WATCHDOG_CORE > select P2SB
On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote: > If a user did choose to enable Siemens Simatic platform support they > likely want that driver to be enabled without having to flip more config > switches. So we make the watchdog driver config switch default to the > platform driver switches value. > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index ee97d89dfc11..ccdbd1109a32 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1681,6 +1681,7 @@ config NIC7018_WDT > config SIEMENS_SIMATIC_IPC_WDT > tristate "Siemens Simatic IPC Watchdog" > depends on SIEMENS_SIMATIC_IPC > + default SIEMENS_SIMATIC_IPC Why not just "default y" ? That does the same (it will be set to m if SIEMENS_SIMATIC_IPC=m) without the complexity. Guenter > select WATCHDOG_CORE > select P2SB > help > -- > 2.41.0 >
Am Tue, 18 Jul 2023 08:07:52 -0700 schrieb Guenter Roeck <linux@roeck-us.net>: > On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote: > > If a user did choose to enable Siemens Simatic platform support they > > likely want that driver to be enabled without having to flip more > > config switches. So we make the watchdog driver config switch > > default to the platform driver switches value. > > > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > > --- > > drivers/watchdog/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > > index ee97d89dfc11..ccdbd1109a32 100644 > > --- a/drivers/watchdog/Kconfig > > +++ b/drivers/watchdog/Kconfig > > @@ -1681,6 +1681,7 @@ config NIC7018_WDT > > config SIEMENS_SIMATIC_IPC_WDT > > tristate "Siemens Simatic IPC Watchdog" > > depends on SIEMENS_SIMATIC_IPC > > + default SIEMENS_SIMATIC_IPC > > Why not just "default y" ? That does the same (it will be set to m if > SIEMENS_SIMATIC_IPC=m) without the complexity. I see. Thanks! In that case i will go for "default y" and not "default m" which i wrote about in the other mail. Henning > Guenter > > > select WATCHDOG_CORE > > select P2SB > > help > > -- > > 2.41.0 > >
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index ee97d89dfc11..ccdbd1109a32 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -1681,6 +1681,7 @@ config NIC7018_WDT config SIEMENS_SIMATIC_IPC_WDT tristate "Siemens Simatic IPC Watchdog" depends on SIEMENS_SIMATIC_IPC + default SIEMENS_SIMATIC_IPC select WATCHDOG_CORE select P2SB help
If a user did choose to enable Siemens Simatic platform support they likely want that driver to be enabled without having to flip more config switches. So we make the watchdog driver config switch default to the platform driver switches value. Signed-off-by: Henning Schild <henning.schild@siemens.com> --- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+)