| Message ID | 2703565.mvXUDI8C0e@kreacher |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] ACPI: processor: Refine messages in acpi_early_processor_control_setup() | expand |
On 7/19/2023 6:02 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > The source and meaning of the messages printed by > acpi_early_processor_control_setup() is unclear, so add a pr_fmt() > definition to acpi_processor.c and expand the messages to make it > clear that they are about CPUs. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > > Based on linux-next. > > --- > drivers/acpi/acpi_processor.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > Index: linux-pm/drivers/acpi/acpi_processor.c > =================================================================== > --- linux-pm.orig/drivers/acpi/acpi_processor.c > +++ linux-pm/drivers/acpi/acpi_processor.c > @@ -9,6 +9,7 @@ > * Copyright (C) 2013, Intel Corporation > * Rafael J. Wysocki <rafael.j.wysocki@intel.com> > */ > +#define pr_fmt(fmt) "ACPI: " fmt > > #include <linux/acpi.h> > #include <linux/device.h> > @@ -611,9 +612,9 @@ static bool __init acpi_early_processor_ > void __init acpi_early_processor_control_setup(void) > { > if (acpi_early_processor_osc()) { > - pr_info("_OSC evaluated successfully\n"); > + pr_info("_OSC evaluated successfully for all CPUs\n"); > } else { > - pr_info("_OSC evaluation failed, trying _PDC\n"); > + pr_info("_OSC evaluation for CPUs failed, trying _PDC\n"); > acpi_early_processor_set_pdc(); > } > } Looks good to me, Reviewed-by: Michal Wilczynski <michal.wilczynski@intel.com> > > >
Index: linux-pm/drivers/acpi/acpi_processor.c =================================================================== --- linux-pm.orig/drivers/acpi/acpi_processor.c +++ linux-pm/drivers/acpi/acpi_processor.c @@ -9,6 +9,7 @@ * Copyright (C) 2013, Intel Corporation * Rafael J. Wysocki <rafael.j.wysocki@intel.com> */ +#define pr_fmt(fmt) "ACPI: " fmt #include <linux/acpi.h> #include <linux/device.h> @@ -611,9 +612,9 @@ static bool __init acpi_early_processor_ void __init acpi_early_processor_control_setup(void) { if (acpi_early_processor_osc()) { - pr_info("_OSC evaluated successfully\n"); + pr_info("_OSC evaluated successfully for all CPUs\n"); } else { - pr_info("_OSC evaluation failed, trying _PDC\n"); + pr_info("_OSC evaluation for CPUs failed, trying _PDC\n"); acpi_early_processor_set_pdc(); } }