diff mbox series

[1/2] arm64: dts: qcom: sc8180x-primus: remove superfluous "input-enable"

Message ID 20230717210055.21979-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series [1/2] arm64: dts: qcom: sc8180x-primus: remove superfluous "input-enable" | expand

Commit Message

Krzysztof Kozlowski July 17, 2023, 9 p.m. UTC 
Pin configuration property "input-enable" was used with the intention to
disable the output, but this is done by default by Linux drivers.  Since
commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use
output-disable, not input-enable") the property is not accepted anymore:

  sc8180x-primus.dtb: pinctrl@3100000: hall-int-active-state: 'oneOf' conditional failed, one must be fixed:
    'bias-disable', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

That's my favorite commit.
---
 arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
index 9b8695b92c48..aaac2da69286 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
@@ -580,7 +580,6 @@  hall_int_active_state: hall-int-active-state {
 		pins = "gpio121";
 		function = "gpio";
 
-		input-enable;
 		bias-disable;
 	};
 
@@ -590,7 +589,6 @@  int-n-pins {
 			function = "gpio";
 
 			bias-pull-up;
-			intput-enable;
 		};
 
 		kp-disable-pins {
@@ -639,7 +637,6 @@  tp-int-pins {
 			function = "gpio";
 
 			bias-disable;
-			input-enable;
 		};
 
 		tp-close-n-pins {
@@ -647,7 +644,6 @@  tp-close-n-pins {
 			function = "gpio";
 
 			bias-disable;
-			input-enable;
 		};
 	};
 
@@ -656,7 +652,6 @@  int-n-pins {
 			pins = "gpio122";
 			function = "gpio";
 
-			input-enable;
 			bias-disable;
 		};