| Message ID | 20230713040518.13734-1-machel@vivo.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net,v1] ath6kl:Fix error checking for debugfs_create_dir() | expand |
Paolo Abeni <pabeni@redhat.com> writes: > On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote: >> The debugfs_create_dir() function returns error pointers, >> it never returns NULL. Most incorrect error checks were fixed, >> but the one in ath6kl_debug_init_fs() was forgotten. >> >> Fix the remaining error check. >> >> Signed-off-by: Wang Ming <machel@vivo.com> >> >> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs") > > The SoB tag should be after the 'Fixes' one and you must avoid empty > lines in between. > > (The same applies to your other patch) And the same as with the ath9k patch: this should go to ath-next, not net.
diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c index 433a047f3747..505af195e299 100644 --- a/drivers/net/wireless/ath/ath6kl/debug.c +++ b/drivers/net/wireless/ath/ath6kl/debug.c @@ -1793,7 +1793,7 @@ int ath6kl_debug_init_fs(struct ath6kl *ar) { ar->debugfs_phy = debugfs_create_dir("ath6kl", ar->wiphy->debugfsdir); - if (!ar->debugfs_phy) + if (IS_ERR(ar->debugfs_phy)) return -ENOMEM; debugfs_create_file("tgt_stats", 0400, ar->debugfs_phy, ar,
The debugfs_create_dir() function returns error pointers, it never returns NULL. Most incorrect error checks were fixed, but the one in ath6kl_debug_init_fs() was forgotten. Fix the remaining error check. Signed-off-by: Wang Ming <machel@vivo.com> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs") --- drivers/net/wireless/ath/ath6kl/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)