diff mbox series

[09/10] qla2xxx: fix inconsistent TMF timeout

Message ID 20230712090535.34894-10-njavali@marvell.com
State Superseded
Headers show
Series qla2xxx driver bug fixes | expand

Commit Message

Nilesh Javali July 12, 2023, 9:05 a.m. UTC 
From: Quinn Tran <qutran@marvell.com>

Different behavior were experienced of session being
torn down vs not, when TMF is timed out. When FW detects
the time out, the session is torn down.  When driver detects
the time out, the session is not torn down.

Allow TMF error to return to upper layer without session
tear down.

Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_isr.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Himanshu Madhani July 13, 2023, 7:34 p.m. UTC | #1 
> On Jul 12, 2023, at 2:05 AM, Nilesh Javali <njavali@marvell.com> wrote:
> 
> From: Quinn Tran <qutran@marvell.com>
> 
> Different behavior were experienced of session being
> torn down vs not, when TMF is timed out. When FW detects
> the time out, the session is torn down.  When driver detects
> the time out, the session is not torn down.
> 
> Allow TMF error to return to upper layer without session
> tear down.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Quinn Tran <qutran@marvell.com>
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index eb8480a0d7b0..aba39127474a 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2543,7 +2543,6 @@ qla24xx_tm_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, void *tsk)
> case CS_PORT_BUSY:
> case CS_INCOMPLETE:
> case CS_PORT_UNAVAILABLE:
> - case CS_TIMEOUT:
> case CS_RESET:
> if (atomic_read(&fcport->state) == FCS_ONLINE) {
> ql_dbg(ql_dbg_disc, fcport->vha, 0x3021,
> -- 
> 2.23.1
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index eb8480a0d7b0..aba39127474a 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2543,7 +2543,6 @@  qla24xx_tm_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, void *tsk)
 	case CS_PORT_BUSY:
 	case CS_INCOMPLETE:
 	case CS_PORT_UNAVAILABLE:
-	case CS_TIMEOUT:
 	case CS_RESET:
 		if (atomic_read(&fcport->state) == FCS_ONLINE) {
 			ql_dbg(ql_dbg_disc, fcport->vha, 0x3021,