diff mbox series

scsi: aic7xxx: fix firmware build fatal error

Message ID ZK0XIj6XzY5MCvtd@fedora
State New
Headers show
Series scsi: aic7xxx: fix firmware build fatal error | expand

Commit Message

Wang Jinchao July 11, 2023, 8:47 a.m. UTC 
When building with CONFIG_AIC7XXX_BUILD_FIRMWARE=y, two fatal errors
are reported as shown below:
> aicasm_gram.tab.c:203:10: fatal error: aicasm_gram.tab.h:
> No such file or directory
> aicasm_macro_gram.tab.c:167:10: fatal error: aicasm_macro_gram.tab.h:
> No such file or directory
Fix these issues to make randconfig builds more reliable.

Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
---
 drivers/scsi/aic7xxx/aicasm/Makefile | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

Comments

Martin K. Petersen July 31, 2023, 4:12 p.m. UTC | #1 
Wang,

> When building with CONFIG_AIC7XXX_BUILD_FIRMWARE=y, two fatal errors
> are reported as shown below:
>> aicasm_gram.tab.c:203:10: fatal error: aicasm_gram.tab.h:
>> No such file or directory
>> aicasm_macro_gram.tab.c:167:10: fatal error: aicasm_macro_gram.tab.h:
>> No such file or directory
> Fix these issues to make randconfig builds more reliable.

Applied to 6.6/scsi-staging, thanks!
Martin K. Petersen Aug. 8, 2023, 2:50 a.m. UTC | #2 
On Tue, 11 Jul 2023 16:47:30 +0800, Wang Jinchao wrote:

> When building with CONFIG_AIC7XXX_BUILD_FIRMWARE=y, two fatal errors
> are reported as shown below:
> > aicasm_gram.tab.c:203:10: fatal error: aicasm_gram.tab.h:
> > No such file or directory
> > aicasm_macro_gram.tab.c:167:10: fatal error: aicasm_macro_gram.tab.h:
> > No such file or directory
> Fix these issues to make randconfig builds more reliable.
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: aic7xxx: fix firmware build fatal error
      https://git.kernel.org/mkp/scsi/c/ec6c7c9f5fc4
diff mbox series

Patch

diff --git a/drivers/scsi/aic7xxx/aicasm/Makefile b/drivers/scsi/aic7xxx/aicasm/Makefile
index 243adb0a38d1..a3f2357a3f08 100644
--- a/drivers/scsi/aic7xxx/aicasm/Makefile
+++ b/drivers/scsi/aic7xxx/aicasm/Makefile
@@ -61,23 +61,11 @@  $(OUTDIR)/aicdb.h:
 clean:
 	rm -f $(clean-files)
 
-# Create a dependency chain in generated files
-# to avoid concurrent invocations of the single
-# rule that builds them all.
-$(OUTDIR)/aicasm_gram.c: $(OUTDIR)/aicasm_gram.h
 $(OUTDIR)/aicasm_gram.c $(OUTDIR)/aicasm_gram.h: aicasm_gram.y
-	$(YACC) $(YFLAGS) -b $(<:.y=) $<
-	mv $(<:.y=).tab.c $(OUTDIR)/$(<:.y=.c)
-	mv $(<:.y=).tab.h $(OUTDIR)/$(<:.y=.h)
-
-# Create a dependency chain in generated files
-# to avoid concurrent invocations of the single
-# rule that builds them all.
-$(OUTDIR)/aicasm_macro_gram.c: $(OUTDIR)/aicasm_macro_gram.h
+	$(YACC) $(YFLAGS) -b $(<:.y=) $< -o $(OUTDIR)/$(<:.y=.c)
+
 $(OUTDIR)/aicasm_macro_gram.c $(OUTDIR)/aicasm_macro_gram.h: aicasm_macro_gram.y
-	$(YACC) $(YFLAGS) -b $(<:.y=) -p mm $<
-	mv $(<:.y=).tab.c $(OUTDIR)/$(<:.y=.c)
-	mv $(<:.y=).tab.h $(OUTDIR)/$(<:.y=.h)
+	$(YACC) $(YFLAGS) -b $(<:.y=) -p mm $< -o $(OUTDIR)/$(<:.y=.c)
 
 $(OUTDIR)/aicasm_scan.c: aicasm_scan.l
 	$(LEX) $(LFLAGS) -o $@ $<