diff mbox series

wifi: ath10k: simplify ath10k_peer_create()

Message ID 20230704180617.84948-1-dmantipov@yandex.ru
State New
Headers show
Series wifi: ath10k: simplify ath10k_peer_create() | expand

Commit Message

Dmitry Antipov July 4, 2023, 6:06 p.m. UTC
Use convenient 'list_count_nodes()' in 'ath10k_peer_create()',
thus making the latter a bit smaller and simpler.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
 drivers/net/wireless/ath/ath10k/mac.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

Comments

Kalle Valo Oct. 3, 2023, 2:21 p.m. UTC | #1
Dmitry Antipov <dmantipov@yandex.ru> wrote:

> Use convenient 'list_count_nodes()' in 'ath10k_peer_create()',
> thus making the latter a bit smaller and simpler.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

322a487c53f8 wifi: ath10k: simplify ath10k_peer_create()
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 03e7bc5b6c0b..6d14e58b98af 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -728,20 +728,13 @@  static int ath10k_peer_create(struct ath10k *ar,
 			      const u8 *addr,
 			      enum wmi_peer_type peer_type)
 {
-	struct ath10k_vif *arvif;
 	struct ath10k_peer *peer;
-	int num_peers = 0;
 	int ret;
 
 	lockdep_assert_held(&ar->conf_mutex);
 
-	num_peers = ar->num_peers;
-
-	/* Each vdev consumes a peer entry as well */
-	list_for_each_entry(arvif, &ar->arvifs, list)
-		num_peers++;
-
-	if (num_peers >= ar->max_num_peers)
+	/* Each vdev consumes a peer entry as well. */
+	if (ar->num_peers + list_count_nodes(&ar->arvifs) >= ar->max_num_peers)
 		return -ENOBUFS;
 
 	ret = ath10k_wmi_peer_create(ar, vdev_id, addr, peer_type);