| Message ID | 1465944212-17079-3-git-send-email-john.stultz@linaro.org |
|---|---|
| State | Accepted |
| Commit | 417e06bb3f281e6dddbcad4d5108779718857cc4 |
| Headers | show |
On Tue, 14 Jun 2016, John Stultz wrote: > While trying to get the powerkey to function, I found when > pressing the key, I would get infinitely repeating interrupts. > > After digging around a bit, it seems we didn't set the ack_base > value for the regmap irqchip logic, so nothing was acking the > interrupt. > > This patch adds the ack_base, which seems to make things work. > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> > Cc: Feng Chen <puck.chen@hisilicon.com> > Cc: Wei Xu <xuwei5@hisilicon.com> > Cc: Guodong Xu <guodong.xu@linaro.org> > Acked-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > drivers/mfd/hi655x-pmic.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c > index 05ddc78..68ab370 100644 > --- a/drivers/mfd/hi655x-pmic.c > +++ b/drivers/mfd/hi655x-pmic.c > @@ -45,6 +45,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = { > .num_regs = 1, > .num_irqs = ARRAY_SIZE(hi655x_irqs), > .status_base = HI655X_IRQ_STAT_BASE, > + .ack_base = HI655X_IRQ_STAT_BASE, > .mask_base = HI655X_IRQ_MASK_BASE, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 05ddc78..68ab370 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -45,6 +45,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = { .num_regs = 1, .num_irqs = ARRAY_SIZE(hi655x_irqs), .status_base = HI655X_IRQ_STAT_BASE, + .ack_base = HI655X_IRQ_STAT_BASE, .mask_base = HI655X_IRQ_MASK_BASE, };