| Message ID | 1465915719-8409-6-git-send-email-sudeep.holla@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Daniel, On 27/06/16 15:33, Daniel Lezcano wrote: > On 06/14/2016 04:48 PM, Sudeep Holla wrote: >> Now that ACPI processor idle driver supports LPI(Low Power Idle), lets >> enable ACPI_PROCESSOR_IDLE for ARM64 too. >> >> This patch just removes the IA64 and X86 dependency on >> ACPI_PROCESSOR_IDLE >> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- > > Hi Sudeep, > > now that ACPI processor supports ARM64 did you check the > CPUIDLE_DRIVER_STATE_START trick in the code and its derivative ? > No, that is used only for C-State and ARM64 doesn't support it. Patch 1/5 puts all the C-State code under #ifdef so that it's not compiled on ARM64. > I deleted the patch 2/5 but there is a place where: > Sorry, I don't follow what you mean by that. > if (max_cstate=0) > max_cstate=1; > > Probably this is because the POLL state is inserted, so there is always > an idle state. But for ARM, that is not the case. > Yes > Also, there are some places where the idle state index begins to 1. I > think it should be 0 for ARM. > Yes for LPI, it does start from 0. -- Regards, Sudeep
On 06/27/2016 05:11 PM, Sudeep Holla wrote: > > > On 27/06/16 16:08, Daniel Lezcano wrote: >> On 06/27/2016 05:06 PM, Sudeep Holla wrote: > > [...] > >>> Ah ok, anyways LPI always starts from index 0. IIUC that was your main >>> concern. >> >> Do you have a repo where I can see the code ? >> > > Yes, you can get it from [1] Great. Thanks Sudeep ! > Regards, > Sudeep > > [1] http://git.kernel.org/sudeep.holla/linux/h/for_review/arm64_lpi -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 1358fb7d7a68..d74275c0f374 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -238,7 +238,7 @@ config ACPI_CPPC_LIB config ACPI_PROCESSOR tristate "Processor" depends on X86 || IA64 || ARM64 - select ACPI_PROCESSOR_IDLE if X86 || IA64 + select ACPI_PROCESSOR_IDLE select ACPI_CPU_FREQ_PSS if X86 || IA64 default y help
Now that ACPI processor idle driver supports LPI(Low Power Idle), lets enable ACPI_PROCESSOR_IDLE for ARM64 too. This patch just removes the IA64 and X86 dependency on ACPI_PROCESSOR_IDLE Cc: linux-arm-kernel@lists.infradead.org Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/acpi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4