diff mbox series

[1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

Message ID 1688650209-25119-2-git-send-email-quic_rohiagar@quicinc.com
State Superseded
Headers show
Series Add support for pinctrl in pmic chips. | expand

Commit Message

Rohit Agarwal July 6, 2023, 1:30 p.m. UTC
Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
binding.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rohit Agarwal July 6, 2023, 3:11 p.m. UTC | #1
On 7/6/2023 8:34 PM, Konrad Dybcio wrote:
> On 6.07.2023 16:45, Rohit Agarwal wrote:
>> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>>> binding.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>>> I doubt that all your patches here and other patchsets are v1. Otherwise
>>> how did you get my Acks and Rbs? Please use proper versioning and
>>> provide changelog.
>>>
>>> What changed here?
>> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
>> down according to the subsystem/maintainer.
>> Since it got broken down into multiple smaller series, I didnt include the versioning.
> All of that information should be included in the cover letter, to
> limit confusion both for maintainers and patch workflow tools.
>
> Since these patches all come from a separate series, it would be
> good for you to version this one as v(BIG_SERIES_REVISION)+1 because
> they've already been on LKML at least once. That would especially hold
> true if this revision included any changes.
Understood. Will send all the smaller series again with v2 as version 
with changelog.

Thanks,
Rohit.
> Konrad
>> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/
>>
>>> Best regards,
>>> Krzysztof
>>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 8aaf501..3585031 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -26,6 +26,7 @@  properties:
           - qcom,pm6350-gpio
           - qcom,pm7250b-gpio
           - qcom,pm7325-gpio
+          - qcom,pm7550ba-gpio
           - qcom,pm8005-gpio
           - qcom,pm8008-gpio
           - qcom,pm8018-gpio
@@ -172,6 +173,7 @@  allOf:
         compatible:
           contains:
             enum:
+              - qcom,pm7550ba-gpio
               - qcom,pm8226-gpio
               - qcom,pm8350b-gpio
               - qcom,pm8550ve-gpio
@@ -413,6 +415,7 @@  $defs:
                  - gpio1-gpio9 for pm6350
                  - gpio1-gpio12 for pm7250b
                  - gpio1-gpio10 for pm7325
+                 - gpio1-gpio8 for pm7550ba
                  - gpio1-gpio4 for pm8005
                  - gpio1-gpio2 for pm8008
                  - gpio1-gpio6 for pm8018