[v1,08/12] HID: cp2112: Define all GPIO mask and use it

Message ID	20230703185222.50554-9-andriy.shevchenko@linux.intel.com
State	Accepted
Commit	ee0682b0f241e35c3775f77acf71b20cf4d6830e
Headers	show Return-Path: <linux-input-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Andy Shevchenko <andy@kernel.org> Subject: [PATCH v1 08/12] HID: cp2112: Define all GPIO mask and use it Date: Mon, 3 Jul 2023 21:52:18 +0300 Message-Id: <20230703185222.50554-9-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	HID: cp2112: Cleanups and refactorings \| expand [v1,00/12] HID: cp2112: Cleanups and refactorings [v1,01/12] lib/string_choices: Add str_write_read() helper [v1,02/12] HID: cp2112: Use str_write_read() and str_read_write() [v1,03/12] HID: cp2112: Make irq_chip immutable [v1,04/12] HID: cp2112: Switch to for_each_set_bit() to simplify the code [v1,05/12] HID: cp2112: Don't call ->to_irq() explicitly [v1,06/12] HID: cp2112: Remove dead code [v1,07/12] HID: cp2112: Define maximum GPIO constant and use it [v1,08/12] HID: cp2112: Define all GPIO mask and use it [v1,09/12] HID: cp2112: Use BIT() in GPIO setter and getter [v1,10/12] HID: cp2112: Use sysfs_emit() to instead of scnprintf() [v1,11/12] HID: cp2112: Convert to DEVICE_ATTR_RW() [v1,12/12] HID: cp2112: Use octal permissions

Message ID

20230703185222.50554-9-andriy.shevchenko@linux.intel.com

State

Accepted

Commit

ee0682b0f241e35c3775f77acf71b20cf4d6830e

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Andy Shevchenko <andy@kernel.org>
Subject: [PATCH v1 08/12] HID: cp2112: Define all GPIO mask and use it
Date: Mon,  3 Jul 2023 21:52:18 +0300
Message-Id: <20230703185222.50554-9-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com>
References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

HID: cp2112: Cleanups and refactorings | expand

Commit Message

Andy Shevchenko July 3, 2023, 6:52 p.m. UTC

Define all GPIO mask and use it in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/hid/hid-cp2112.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index c8c59d70500e..37ed7fc54770 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -32,6 +32,7 @@ 
 #define CP2112_GPIO_GET_LENGTH			2
 #define CP2112_GPIO_SET_LENGTH			3
 #define CP2112_GPIO_MAX_GPIO			8
+#define CP2112_GPIO_ALL_GPIO_MASK		GENMASK(7, 0)
 
 enum {
 	CP2112_GPIO_CONFIG		= 0x02,
@@ -173,7 +174,7 @@  struct cp2112_device {
 	u8 gpio_prev_state;
 };
 
-static int gpio_push_pull = 0xFF;
+static int gpio_push_pull = CP2112_GPIO_ALL_GPIO_MASK;
 module_param(gpio_push_pull, int, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(gpio_push_pull, "GPIO push-pull configuration bitmask");
 
@@ -226,7 +227,7 @@  static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 	mutex_lock(&dev->lock);
 
 	buf[0] = CP2112_GPIO_SET;
-	buf[1] = value ? 0xff : 0;
+	buf[1] = value ? CP2112_GPIO_ALL_GPIO_MASK : 0;
 	buf[2] = 1 << offset;
 
 	ret = hid_hw_raw_request(hdev, CP2112_GPIO_SET, buf,

[v1,08/12] HID: cp2112: Define all GPIO mask and use it

Commit Message

Patch