| Message ID | 20230630144006.1513270-4-pan@semihalf.com |
|---|---|
| State | New |
| Headers | show |
| Series | Google Chameleon v3 video driver | expand |
On Fri, Jun 30, 2023 at 04:40:06PM +0200, Paweł Anikiel wrote: > Add node for the video system device. > > Signed-off-by: Paweł Anikiel <pan@semihalf.com> > --- > .../socfpga/socfpga_arria10_chameleonv3.dts | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > index 422d00cd4c74..5e66363d4ab5 100644 > --- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > @@ -10,6 +10,60 @@ / { > compatible = "google,chameleon-v3", "enclustra,mercury-aa1", > "altr,socfpga-arria10", "altr,socfpga"; > > + soc { > + video@c0060500 { > + compatible = "google,chv3-video"; This compatible does not seem to be documented & I did not see a comment about the lack of a binding in the cover letter. What am I missing?
On Fri, Jun 30, 2023 at 8:26 PM Conor Dooley <conor@kernel.org> wrote: > > On Fri, Jun 30, 2023 at 04:40:06PM +0200, Paweł Anikiel wrote: > > Add node for the video system device. > > > > Signed-off-by: Paweł Anikiel <pan@semihalf.com> > > --- > > .../socfpga/socfpga_arria10_chameleonv3.dts | 54 +++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > > > diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > > index 422d00cd4c74..5e66363d4ab5 100644 > > --- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > > +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > > @@ -10,6 +10,60 @@ / { > > compatible = "google,chameleon-v3", "enclustra,mercury-aa1", > > "altr,socfpga-arria10", "altr,socfpga"; > > > > + soc { > > + video@c0060500 { > > + compatible = "google,chv3-video"; > > This compatible does not seem to be documented & I did not see a comment > about the lack of a binding in the cover letter. What am I missing? Yes, the compatible is not documented for now (I'll do that in a later patchset), sorry for not mentioning that in the cover letter.
On Mon, Jul 3, 2023 at 2:33 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 03/07/2023 13:44, Paweł Anikiel wrote: > >>> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > >>> index 422d00cd4c74..5e66363d4ab5 100644 > >>> --- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > >>> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > >>> @@ -10,6 +10,60 @@ / { > >>> compatible = "google,chameleon-v3", "enclustra,mercury-aa1", > >>> "altr,socfpga-arria10", "altr,socfpga"; > >>> > >>> + soc { > >>> + video@c0060500 { > >>> + compatible = "google,chv3-video"; > >> > >> This compatible does not seem to be documented & I did not see a comment > >> about the lack of a binding in the cover letter. What am I missing? > > > > Yes, the compatible is not documented for now (I'll do that in a later > > patchset), sorry for not mentioning that in the cover letter. > > You cannot add undocumented compatible. This cannot be fixed in "a later > patchset". I meant later revision, I'm certainly not expecting this one to land (I sent is as an RFC). Is it really necessary to document the compatible to get any form of feedback on the overall structure of the driver?
On 04/07/2023 18:16, Paweł Anikiel wrote: >>>>> + soc { >>>>> + video@c0060500 { >>>>> + compatible = "google,chv3-video"; >>>> >>>> This compatible does not seem to be documented & I did not see a comment >>>> about the lack of a binding in the cover letter. What am I missing? >>> >>> Yes, the compatible is not documented for now (I'll do that in a later >>> patchset), sorry for not mentioning that in the cover letter. >> >> You cannot add undocumented compatible. This cannot be fixed in "a later >> patchset". > > I meant later revision, I'm certainly not expecting this one to land > (I sent is as an RFC). That's not clear. RFC is interpreted differently by different people. Some just ignore it entirely, some still review. > Is it really necessary to document the > compatible to get any form of feedback on the overall structure of the > driver? Depends on the person. Anyway no problem for me - I will just ignore the patchset. Best regards, Krzysztof
On Tue, Jul 04, 2023 at 06:23:10PM +0200, Krzysztof Kozlowski wrote: > On 04/07/2023 18:16, Paweł Anikiel wrote: > >>>>> + soc { > >>>>> + video@c0060500 { > >>>>> + compatible = "google,chv3-video"; > >>>> > >>>> This compatible does not seem to be documented & I did not see a comment > >>>> about the lack of a binding in the cover letter. What am I missing? > >>> > >>> Yes, the compatible is not documented for now (I'll do that in a later > >>> patchset), sorry for not mentioning that in the cover letter. > >> > >> You cannot add undocumented compatible. This cannot be fixed in "a later > >> patchset". > > > > I meant later revision, I'm certainly not expecting this one to land > > (I sent is as an RFC). > > That's not clear. RFC is interpreted differently by different people. > Some just ignore it entirely, some still review. > > > Is it really necessary to document the > > compatible to get any form of feedback on the overall structure of the > > driver? > > Depends on the person. Anyway no problem for me - I will just ignore the > patchset. FWIW, I was asking about it in case you weren't aware Paweł that you would need to document the properties, since it wasn't mentioned anywhere.
diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts index 422d00cd4c74..5e66363d4ab5 100644 --- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts @@ -10,6 +10,60 @@ / { compatible = "google,chameleon-v3", "enclustra,mercury-aa1", "altr,socfpga-arria10", "altr,socfpga"; + soc { + video@c0060500 { + compatible = "google,chv3-video"; + reg = <0xc0060500 0x100>, + <0xc0060600 0x100>, + <0xc0060700 0x100>, + <0xc0060800 0x100>, + <0xc0060900 0x100>, + <0xc0060a00 0x100>, + <0xc0062000 0x800>, + <0xc0064000 0x800>, + <0xc0060f20 0x10>, + <0xc0060f30 0x10>, + <0xc0060f40 0x10>, + <0xc0060f50 0x10>, + <0xc0060f60 0x10>, + <0xc0060f70 0x10>, + <0xc0060f80 0x10>, + <0xc0060fe0 0x10>; + reg-names = "fb0", + "fb_mst1", + "fb_mst2", + "fb_mst3", + "fb_mst4", + "fb_sst", + "dp_mst", + "dp_sst", + "fb0_irq", + "fb_mst1_irq", + "fb_mst2_irq", + "fb_mst3_irq", + "fb_mst4_irq", + "fb_sst_irq", + "dp_mst_irq", + "dp_sst_irq"; + interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>, + <0 22 IRQ_TYPE_LEVEL_HIGH>, + <0 23 IRQ_TYPE_LEVEL_HIGH>, + <0 24 IRQ_TYPE_LEVEL_HIGH>, + <0 25 IRQ_TYPE_LEVEL_HIGH>, + <0 26 IRQ_TYPE_LEVEL_HIGH>, + <0 27 IRQ_TYPE_LEVEL_HIGH>, + <0 33 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "fb0", + "fb_mst1", + "fb_mst2", + "fb_mst3", + "fb_mst4", + "fb_sst", + "dp_mst", + "dp_sst"; + }; + }; + aliases { serial0 = &uart0; i2c0 = &i2c0;
Add node for the video system device. Signed-off-by: Paweł Anikiel <pan@semihalf.com> --- .../socfpga/socfpga_arria10_chameleonv3.dts | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+)