diff mbox series

arch/sparc: Add module license and description for fbdev helpers

Message ID 20230627145843.31794-1-tzimmermann@suse.de
State New
Headers show
Series arch/sparc: Add module license and description for fbdev helpers | expand

Commit Message

Thomas Zimmermann June 27, 2023, 2:58 p.m. UTC
Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers
on sparc. Fixes the following error:

ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o

Reported-by: Guenter Roeck <linux@roeck-us.net>
Closes: https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c9311563b8@roeck-us.net/
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4eec0b3048fc ("arch/sparc: Implement fb_is_primary_device() in source file")
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Helge Deller <deller@gmx.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 arch/sparc/video/fbdev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Randy Dunlap June 27, 2023, 3:33 p.m. UTC | #1
On 6/27/23 07:58, Thomas Zimmermann wrote:
> Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers
> on sparc. Fixes the following error:
> 
> ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c9311563b8@roeck-us.net/
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4eec0b3048fc ("arch/sparc: Implement fb_is_primary_device() in source file")
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  arch/sparc/video/fbdev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/sparc/video/fbdev.c b/arch/sparc/video/fbdev.c
> index 25837f128132d..bff66dd1909a4 100644
> --- a/arch/sparc/video/fbdev.c
> +++ b/arch/sparc/video/fbdev.c
> @@ -21,3 +21,6 @@ int fb_is_primary_device(struct fb_info *info)
>  	return 0;
>  }
>  EXPORT_SYMBOL(fb_is_primary_device);
> +
> +MODULE_DESCRIPTION("Sparc fbdev helpers");
> +MODULE_LICENSE("GPL");
Sam Ravnborg June 27, 2023, 6:20 p.m. UTC | #2
On Tue, Jun 27, 2023 at 04:58:20PM +0200, Thomas Zimmermann wrote:
> Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers
> on sparc. Fixes the following error:
> 
> ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c9311563b8@roeck-us.net/
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4eec0b3048fc ("arch/sparc: Implement fb_is_primary_device() in source file")
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

	Sam
Helge Deller June 30, 2023, 9:43 a.m. UTC | #3
On 6/27/23 16:58, Thomas Zimmermann wrote:
> Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers
> on sparc. Fixes the following error:
>
> ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c9311563b8@roeck-us.net/
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4eec0b3048fc ("arch/sparc: Implement fb_is_primary_device() in source file")
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   arch/sparc/video/fbdev.c | 3 +++
>   1 file changed, 3 insertions(+)

I've queued it up in the fbdev git tree but will drop it anytime
if someone prefers to take this patch through another tree....

Thanks!
Helge


>
> diff --git a/arch/sparc/video/fbdev.c b/arch/sparc/video/fbdev.c
> index 25837f128132d..bff66dd1909a4 100644
> --- a/arch/sparc/video/fbdev.c
> +++ b/arch/sparc/video/fbdev.c
> @@ -21,3 +21,6 @@ int fb_is_primary_device(struct fb_info *info)
>   	return 0;
>   }
>   EXPORT_SYMBOL(fb_is_primary_device);
> +
> +MODULE_DESCRIPTION("Sparc fbdev helpers");
> +MODULE_LICENSE("GPL");
Thomas Zimmermann June 30, 2023, 10:58 a.m. UTC | #4
Hi Helge

Am 30.06.23 um 11:43 schrieb Helge Deller:
> On 6/27/23 16:58, Thomas Zimmermann wrote:
>> Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers
>> on sparc. Fixes the following error:
>>
>> ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o
>>
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Closes: 
>> https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c9311563b8@roeck-us.net/
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 4eec0b3048fc ("arch/sparc: Implement fb_is_primary_device() in 
>> source file")
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Helge Deller <deller@gmx.de>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Cc: sparclinux@vger.kernel.org
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>   arch/sparc/video/fbdev.c | 3 +++
>>   1 file changed, 3 insertions(+)
> 
> I've queued it up in the fbdev git tree but will drop it anytime
> if someone prefers to take this patch through another tree....

It's in drm-misc-next-fixes already.

Best regards
Thomas

> 
> Thanks!
> Helge
> 
> 
>>
>> diff --git a/arch/sparc/video/fbdev.c b/arch/sparc/video/fbdev.c
>> index 25837f128132d..bff66dd1909a4 100644
>> --- a/arch/sparc/video/fbdev.c
>> +++ b/arch/sparc/video/fbdev.c
>> @@ -21,3 +21,6 @@ int fb_is_primary_device(struct fb_info *info)
>>       return 0;
>>   }
>>   EXPORT_SYMBOL(fb_is_primary_device);
>> +
>> +MODULE_DESCRIPTION("Sparc fbdev helpers");
>> +MODULE_LICENSE("GPL");
>
Helge Deller June 30, 2023, 11:04 a.m. UTC | #5
On 6/30/23 12:58, Thomas Zimmermann wrote:
> Hi Helge
>
> Am 30.06.23 um 11:43 schrieb Helge Deller:
>> On 6/27/23 16:58, Thomas Zimmermann wrote:
>>> Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers
>>> on sparc. Fixes the following error:
>>>
>>> ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o
>>>
>>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>>> Closes: https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c9311563b8@roeck-us.net/
>>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>>> Fixes: 4eec0b3048fc ("arch/sparc: Implement fb_is_primary_device() in source file")
>>> Cc: "David S. Miller" <davem@davemloft.net>
>>> Cc: Helge Deller <deller@gmx.de>
>>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>> Cc: sparclinux@vger.kernel.org
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>>   arch/sparc/video/fbdev.c | 3 +++
>>>   1 file changed, 3 insertions(+)
>>
>> I've queued it up in the fbdev git tree but will drop it anytime
>> if someone prefers to take this patch through another tree....
>
> It's in drm-misc-next-fixes already.

Ok, I'll drop it.
Thanks!
Helge

> Best regards
> Thomas
>
>>
>> Thanks!
>> Helge
>>
>>
>>>
>>> diff --git a/arch/sparc/video/fbdev.c b/arch/sparc/video/fbdev.c
>>> index 25837f128132d..bff66dd1909a4 100644
>>> --- a/arch/sparc/video/fbdev.c
>>> +++ b/arch/sparc/video/fbdev.c
>>> @@ -21,3 +21,6 @@ int fb_is_primary_device(struct fb_info *info)
>>>       return 0;
>>>   }
>>>   EXPORT_SYMBOL(fb_is_primary_device);
>>> +
>>> +MODULE_DESCRIPTION("Sparc fbdev helpers");
>>> +MODULE_LICENSE("GPL");
>>
>
diff mbox series

Patch

diff --git a/arch/sparc/video/fbdev.c b/arch/sparc/video/fbdev.c
index 25837f128132d..bff66dd1909a4 100644
--- a/arch/sparc/video/fbdev.c
+++ b/arch/sparc/video/fbdev.c
@@ -21,3 +21,6 @@  int fb_is_primary_device(struct fb_info *info)
 	return 0;
 }
 EXPORT_SYMBOL(fb_is_primary_device);
+
+MODULE_DESCRIPTION("Sparc fbdev helpers");
+MODULE_LICENSE("GPL");