| Message ID | 20230627085306.6033-1-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Commit | 55c9b1bf29dad107b3871bbb250c00df80a68791 |
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp-pmics: add explicit rtc interrupt parent | expand |
On Tue, 27 Jun 2023 10:53:06 +0200, Johan Hovold wrote: > Unless explicitly specified the interrupt-parent property is inherited > from the parent node on Linux even though this may not be in full > compliance with the devicetree specification. > > Following commit 2d5cab9232ba ("arm64: dts: qcom: sc8280xp-pmics: > Specify interrupt parent explicitly"), add an explicit interrupt parent > also for the PMIC RTC node for the benefit of other operating systems > which may be confused by this omission. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sc8280xp-pmics: add explicit rtc interrupt parent commit: 55c9b1bf29dad107b3871bbb250c00df80a68791 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi index a0ba535bb6c9..80ee12ded4f4 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi @@ -101,7 +101,7 @@ pmk8280_rtc: rtc@6100 { compatible = "qcom,pmk8350-rtc"; reg = <0x6100>, <0x6200>; reg-names = "rtc", "alarm"; - interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>; + interrupts-extended = <&spmi_bus 0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>; wakeup-source; status = "disabled"; };
Unless explicitly specified the interrupt-parent property is inherited from the parent node on Linux even though this may not be in full compliance with the devicetree specification. Following commit 2d5cab9232ba ("arm64: dts: qcom: sc8280xp-pmics: Specify interrupt parent explicitly"), add an explicit interrupt parent also for the PMIC RTC node for the benefit of other operating systems which may be confused by this omission. Note that any such OS must still implement a fallback to the root interrupt domain as most devicetrees are written under the assumption that the interrupt parent is inherited. Reported-by: Patrick Wildt <patrick@blueri.se> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)