| Message ID | 20221209-dt-binding-ufs-v5-3-c9a58c0a53f5@fairphone.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix some issues in QCOM UFS bindings | expand |
On Tue Jun 27, 2023 at 11:55 AM CEST, Rob Herring wrote: > > On Tue, 27 Jun 2023 10:28:03 +0200, Luca Weiss wrote: > > SM8450 actually supports ICE (Inline Crypto Engine) so adjust the > > example to match. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: Unevaluated properties are not allowed ('qcom,ice' was unexpected) > from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# qcom,ice should land with v5.4 https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=29a6d1215b7cd5fdff9c3c31ea26076a694ee0a3 And as mentioned in the cover letter, validation will still fail with without the extra patch linked there (which is not in -next yet). Regards Luca > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221209-dt-binding-ufs-v5-3-c9a58c0a53f5@fairphone.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema.
On Tue Jun 27, 2023 at 12:07 PM CEST, Luca Weiss wrote: > On Tue Jun 27, 2023 at 11:55 AM CEST, Rob Herring wrote: > > > > On Tue, 27 Jun 2023 10:28:03 +0200, Luca Weiss wrote: > > > SM8450 actually supports ICE (Inline Crypto Engine) so adjust the > > > example to match. > > > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > > --- > > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: Unevaluated properties are not allowed ('qcom,ice' was unexpected) > > from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# > > qcom,ice should land with v5.4 Sorry, obviously wrong version: I meant v6.5 > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=29a6d1215b7cd5fdff9c3c31ea26076a694ee0a3 > > And as mentioned in the cover letter, validation will still fail with > without the extra patch linked there (which is not in -next yet). > > Regards > Luca > > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221209-dt-binding-ufs-v5-3-c9a58c0a53f5@fairphone.com > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 2b0831622cf0..462ead5a1cec 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -317,5 +317,6 @@ examples: <0 0>, <0 0>, <0 0>; + qcom,ice = <&ice>; }; };
SM8450 actually supports ICE (Inline Crypto Engine) so adjust the example to match. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 1 + 1 file changed, 1 insertion(+)