diff mbox series

[v9,01/13] dmaengine: fsl-edma: fix build error when arch is s390

Message ID 20230620201221.2580428-2-Frank.Li@nxp.com
State Superseded
Headers show
Series [v9,01/13] dmaengine: fsl-edma: fix build error when arch is s390 | expand

Commit Message

Frank Li June 20, 2023, 8:12 p.m. UTC
fixed build error reported by kernel test robot.

>> s390-linux-ld: fsl-edma-main.c:(.text+0xf4c): undefined reference to `devm_platform_ioremap_resource'
   s390-linux-ld: drivers/dma/idma64.o: in function `idma64_platform_probe':

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306210131.zaHVasxz-lkp@intel.com/
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vinod Koul July 7, 2023, 5:37 a.m. UTC | #1
On 20-06-23, 16:12, Frank Li wrote:
> fixed build error reported by kernel test robot.
> 
> >> s390-linux-ld: fsl-edma-main.c:(.text+0xf4c): undefined reference to `devm_platform_ioremap_resource'
>    s390-linux-ld: drivers/dma/idma64.o: in function `idma64_platform_probe':
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306210131.zaHVasxz-lkp@intel.com/
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 644c188d6a11..c1065c444cde 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -210,7 +210,7 @@ config FSL_DMA
>  
>  config FSL_EDMA
>  	tristate "Freescale eDMA engine support"
> -	depends on OF
> +	depends on ARCH_NXP

That is not really a fix! you are masking this by making the driver
build only on NXP

I think better fix is to depend on HAS_IOMEM

>  	select DMA_ENGINE
>  	select DMA_VIRTUAL_CHANNELS
>  	help
> -- 
> 2.34.1
diff mbox series

Patch

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 644c188d6a11..c1065c444cde 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -210,7 +210,7 @@  config FSL_DMA
 
 config FSL_EDMA
 	tristate "Freescale eDMA engine support"
-	depends on OF
+	depends on ARCH_NXP
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help