| Message ID | 20160606170854.12407-1-lee.jones@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Monday 06 June 2016 10:38 PM, Lee Jones wrote: > On the STiH410 B2120 development board the ports on the Generic PHY > share their reset lines with each other. New functionality in the > reset subsystems forces consumers to be explicit when requesting > shared/exclusive reset lines. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/phy/phy-stih407-usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-stih407-usb.c b/drivers/phy/phy-stih407-usb.c > index 1d5ae5f..b1f44ab 100644 > --- a/drivers/phy/phy-stih407-usb.c > +++ b/drivers/phy/phy-stih407-usb.c > @@ -105,13 +105,13 @@ static int stih407_usb2_picophy_probe(struct platform_device *pdev) > phy_dev->dev = dev; > dev_set_drvdata(dev, phy_dev); > > - phy_dev->rstc = devm_reset_control_get(dev, "global"); > + phy_dev->rstc = devm_reset_control_get_shared(dev, "global"); > if (IS_ERR(phy_dev->rstc)) { > dev_err(dev, "failed to ctrl picoPHY reset\n"); > return PTR_ERR(phy_dev->rstc); > } > > - phy_dev->rstport = devm_reset_control_get(dev, "port"); > + phy_dev->rstport = devm_reset_control_get_exclusive(dev, "port"); > if (IS_ERR(phy_dev->rstport)) { > dev_err(dev, "failed to ctrl picoPHY reset\n"); > return PTR_ERR(phy_dev->rstport); >
diff --git a/drivers/phy/phy-stih407-usb.c b/drivers/phy/phy-stih407-usb.c index 1d5ae5f..b1f44ab 100644 --- a/drivers/phy/phy-stih407-usb.c +++ b/drivers/phy/phy-stih407-usb.c @@ -105,13 +105,13 @@ static int stih407_usb2_picophy_probe(struct platform_device *pdev) phy_dev->dev = dev; dev_set_drvdata(dev, phy_dev); - phy_dev->rstc = devm_reset_control_get(dev, "global"); + phy_dev->rstc = devm_reset_control_get_shared(dev, "global"); if (IS_ERR(phy_dev->rstc)) { dev_err(dev, "failed to ctrl picoPHY reset\n"); return PTR_ERR(phy_dev->rstc); } - phy_dev->rstport = devm_reset_control_get(dev, "port"); + phy_dev->rstport = devm_reset_control_get_exclusive(dev, "port"); if (IS_ERR(phy_dev->rstport)) { dev_err(dev, "failed to ctrl picoPHY reset\n"); return PTR_ERR(phy_dev->rstport);
On the STiH410 B2120 development board the ports on the Generic PHY share their reset lines with each other. New functionality in the reset subsystems forces consumers to be explicit when requesting shared/exclusive reset lines. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/phy/phy-stih407-usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.8.3