| Message ID | 20230613093351.3383-1-oneukum@suse.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | USB: serial-simple: adding Kaufmann RKS+CAN VCP | expand |
On Tue, Jun 13, 2023 at 11:33:51AM +0200, Oliver Neukum wrote: > Adding the device and product ID Can you say something more about the product here (e.g. to indicate that this is indeed a custom firmware that requires a simple driver)? > Reported-by: Kaufmann Automotive GmbH <info@kaufmann-automotive.ch> > Tested-by: Kaufmann Automotive GmbH <info@kaufmann-automotive.ch> > Signed-off-by: Oliver Neukum <oneukum@suse.com> > --- > drivers/usb/serial/usb-serial-simple.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c > index 4c6747889a19..3612031030bb 100644 > --- a/drivers/usb/serial/usb-serial-simple.c > +++ b/drivers/usb/serial/usb-serial-simple.c > @@ -117,6 +117,11 @@ DEVICE(suunto, SUUNTO_IDS); > { USB_DEVICE(0x908, 0x0004) } > DEVICE(siemens_mpi, SIEMENS_IDS); > > +/* KAUFMANN RKS+CAN VCP */ > +#define KAUFMANN_IDS() \ > + { USB_DEVICE(0x16d0, 0x0870) } > +DEVICE(kaufmann, KAUFMANN_IDS); Can you add this one after GOOGLE_IDS() to approximate some ordering? I'll try to move the rest in place later. > + > /* All of the above structures mushed into two lists */ > static struct usb_serial_driver * const serial_drivers[] = { > &carelink_device, > @@ -133,6 +138,7 @@ static struct usb_serial_driver * const serial_drivers[] = { > &hp4x_device, > &suunto_device, > &siemens_mpi_device, > + &kaufmann_device, > NULL > }; > > @@ -151,6 +157,7 @@ static const struct usb_device_id id_table[] = { > HP4X_IDS(), > SUUNTO_IDS(), > SIEMENS_IDS(), > + KAUFMANN_IDS(), > { }, > }; Similar in these two arrays. Johan
Good morning, it is a CAN bus interface / license dongle with a custom firmware. Details about the interface hardware: https[https://shop.dieselschrauber.org/en/can-usb-interface-kit-p-313.php]://[https://shop.dieselschrauber.org/en/can-usb-interface-kit-p-313.php]shop.dieselschrauber.org[https://shop.dieselschrauber.org/en/can-usb-interface-kit-p-313.php]/en/[https://shop.dieselschrauber.org/en/can-usb-interface-kit-p-313.php]can-usb-interface-kit-p-313.php[https://shop.dieselschrauber.org/en/can-usb-interface-kit-p-313.php] Best regards, Rainer 20.06.2023 08:14:25 Johan Hovold <johan@kernel.org>: > On Tue, Jun 13, 2023 at 11:33:51AM +0200, Oliver Neukum wrote: >> Adding the device and product ID > > Can you say something more about the product here (e.g. to indicate that > this is indeed a custom firmware that requires a simple driver)? > >> Reported-by: Kaufmann Automotive GmbH <info@kaufmann-automotive.ch> >> Tested-by: Kaufmann Automotive GmbH <info@kaufmann-automotive.ch> >> Signed-off-by: Oliver Neukum <oneukum@suse.com> >> --- >> drivers/usb/serial/usb-serial-simple.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c >> index 4c6747889a19..3612031030bb 100644 >> --- a/drivers/usb/serial/usb-serial-simple.c >> +++ b/drivers/usb/serial/usb-serial-simple.c >> @@ -117,6 +117,11 @@ DEVICE(suunto, SUUNTO_IDS); >> { USB_DEVICE(0x908, 0x0004) } >> DEVICE(siemens_mpi, SIEMENS_IDS); >> >> +/* KAUFMANN RKS+CAN VCP */ >> +#define KAUFMANN_IDS() \ >> + { USB_DEVICE(0x16d0, 0x0870) } >> +DEVICE(kaufmann, KAUFMANN_IDS); > > Can you add this one after GOOGLE_IDS() to approximate some ordering? > > I'll try to move the rest in place later. > >> + >> /* All of the above structures mushed into two lists */ >> static struct usb_serial_driver * const serial_drivers[] = { >> &carelink_device, >> @@ -133,6 +138,7 @@ static struct usb_serial_driver * const serial_drivers[] = { >> &hp4x_device, >> &suunto_device, >> &siemens_mpi_device, >> + &kaufmann_device, >> NULL >> }; >> >> @@ -151,6 +157,7 @@ static const struct usb_device_id id_table[] = { >> HP4X_IDS(), >> SUUNTO_IDS(), >> SIEMENS_IDS(), >> + KAUFMANN_IDS(), >> { }, >> }; > > Similar in these two arrays. > > Johan
diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c index 4c6747889a19..3612031030bb 100644 --- a/drivers/usb/serial/usb-serial-simple.c +++ b/drivers/usb/serial/usb-serial-simple.c @@ -117,6 +117,11 @@ DEVICE(suunto, SUUNTO_IDS); { USB_DEVICE(0x908, 0x0004) } DEVICE(siemens_mpi, SIEMENS_IDS); +/* KAUFMANN RKS+CAN VCP */ +#define KAUFMANN_IDS() \ + { USB_DEVICE(0x16d0, 0x0870) } +DEVICE(kaufmann, KAUFMANN_IDS); + /* All of the above structures mushed into two lists */ static struct usb_serial_driver * const serial_drivers[] = { &carelink_device, @@ -133,6 +138,7 @@ static struct usb_serial_driver * const serial_drivers[] = { &hp4x_device, &suunto_device, &siemens_mpi_device, + &kaufmann_device, NULL }; @@ -151,6 +157,7 @@ static const struct usb_device_id id_table[] = { HP4X_IDS(), SUUNTO_IDS(), SIEMENS_IDS(), + KAUFMANN_IDS(), { }, }; MODULE_DEVICE_TABLE(usb, id_table);