| Message ID | 20230526-topic-smd_icc-v3-1-5fb7d39b874f@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Restructure RPM SMD ICC | expand |
On Mon, Jun 12, 2023 at 08:24:18PM +0200, Konrad Dybcio wrote: > The SMD RPM interconnect driver requires different icc tags to the > RPMh driver. Add bindings to reflect that. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h > new file mode 100644 > index 000000000000..ef61006c9c58 > --- /dev/null > +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (c) 2023, Linaro Limited > + */ > + > +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H > +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H > + > +#define RPM_ACTIVE_TAG BIT(0) > +#define RPM_SLEEP_TAG BIT(1) BIT(n) doesn't work in dt-bindings (syntax error), can you change this to (1 << 0) / (1 << 1)? Thanks!
On 13.06.2023 13:11, Stephan Gerhold wrote: > On Mon, Jun 12, 2023 at 08:24:18PM +0200, Konrad Dybcio wrote: >> The SMD RPM interconnect driver requires different icc tags to the >> RPMh driver. Add bindings to reflect that. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h >> new file mode 100644 >> index 000000000000..ef61006c9c58 >> --- /dev/null >> +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h >> @@ -0,0 +1,13 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >> +/* >> + * Copyright (c) 2023, Linaro Limited >> + */ >> + >> +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H >> +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H >> + >> +#define RPM_ACTIVE_TAG BIT(0) >> +#define RPM_SLEEP_TAG BIT(1) > > BIT(n) doesn't work in dt-bindings (syntax error), can you change this > to (1 << 0) / (1 << 1)? Just including the binding did not show it.. You're right.. Konrad > > Thanks! >
diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h new file mode 100644 index 000000000000..ef61006c9c58 --- /dev/null +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) 2023, Linaro Limited + */ + +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H + +#define RPM_ACTIVE_TAG BIT(0) +#define RPM_SLEEP_TAG BIT(1) +#define RPM_ALWAYS_TAG (RPM_ACTIVE_TAG | RPM_SLEEP_TAG) + +#endif
The SMD RPM interconnect driver requires different icc tags to the RPMh driver. Add bindings to reflect that. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++ 1 file changed, 13 insertions(+)