| Message ID | 20230607093514.104012-1-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] PCI: endpoint: Remove redundant dev_err(). | expand |
diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c index 1227f059ea12..371d6f80845e 100644 --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c @@ -359,7 +359,6 @@ static int pci_epf_mhi_bind(struct pci_epf *epf) ret = platform_get_irq_byname(pdev, "doorbell"); if (ret < 0) { - dev_err(dev, "Failed to get Doorbell IRQ\n"); iounmap(epf_mhi->mmio); return ret; }
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. Eliminate the following warning: ./drivers/pci/endpoint/functions/pci-epf-mhi.c:362:2-9: line 362 is redundant because platform_get_irq_byname() already prints an error Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5449 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/pci/endpoint/functions/pci-epf-mhi.c | 1 - 1 file changed, 1 deletion(-)