| Message ID | 20230608133108.72655-2-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | misc: Enforce .[ch].inc extension for re-included .c/.h files | expand |
On 8/6/23 15:31, Philippe Mathieu-Daudé wrote: > event_notifier-posix.c is registered in meson's util_ss[] source > set, which is built as libqemuutil.a.p library. Both tools and > system emulation binaries are linked with qemuutil, so there is > no point in including this source file. > > Introduced in commit bd36adb8df ("multi-process: create IOHUB > object to handle irq"). > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > Note, --enable-multiprocess doesn't seem to be covered in CI. > --- > hw/remote/proxy.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c > index 1c7786b52c..2052d721e5 100644 > --- a/hw/remote/proxy.c > +++ b/hw/remote/proxy.c > @@ -22,7 +22,6 @@ > #include "qom/object.h" > #include "qemu/event_notifier.h" > #include "sysemu/kvm.h" > -#include "util/event_notifier-posix.c" Err wrong branch base, please discard this patch which is already in Paolo's queue.
diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c index 1c7786b52c..2052d721e5 100644 --- a/hw/remote/proxy.c +++ b/hw/remote/proxy.c @@ -22,7 +22,6 @@ #include "qom/object.h" #include "qemu/event_notifier.h" #include "sysemu/kvm.h" -#include "util/event_notifier-posix.c" static void probe_pci_info(PCIDevice *dev, Error **errp); static void proxy_device_reset(DeviceState *dev);
event_notifier-posix.c is registered in meson's util_ss[] source set, which is built as libqemuutil.a.p library. Both tools and system emulation binaries are linked with qemuutil, so there is no point in including this source file. Introduced in commit bd36adb8df ("multi-process: create IOHUB object to handle irq"). Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- Note, --enable-multiprocess doesn't seem to be covered in CI. --- hw/remote/proxy.c | 1 - 1 file changed, 1 deletion(-)