| Message ID | 20230601163900.15500-9-manivannan.sadhasivam@linaro.org |
|---|---|
| State | Superseded |
| Headers | show
Return-Path: <linux-arm-msm-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
by smtp.lore.kernel.org (Postfix) with ESMTP id B85C0C77B7A
for <linux-arm-msm@archiver.kernel.org>;
Thu, 1 Jun 2023 16:40:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231831AbjFAQkM (ORCPT
<rfc822;linux-arm-msm@archiver.kernel.org>);
Thu, 1 Jun 2023 12:40:12 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55148 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232319AbjFAQkI (ORCPT
<rfc822;linux-arm-msm@vger.kernel.org>);
Thu, 1 Jun 2023 12:40:08 -0400
Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com
[IPv6:2607:f8b0:4864:20::434])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0D451AE
for <linux-arm-msm@vger.kernel.org>;
Thu, 1 Jun 2023 09:39:47 -0700 (PDT)
Received: by mail-pf1-x434.google.com with SMTP id
d2e1a72fcca58-65292f79456so107430b3a.2
for <linux-arm-msm@vger.kernel.org>;
Thu, 01 Jun 2023 09:39:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1685637587; x=1688229587;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=BAHgbKUGLDFGyzp+XWYZ2sseIunYBsYQIO/Xldf05CU=;
b=ryx0q2tgrm1ZKWtwvRMJ9C4j+popyHn3lXSPJE9WeKkQ8kOC7HrJjfKFRmCDgLK4jz
G+xHfxxcaoeujui+lcZ6sPSDA/hrnRZY37AoAlRfbMdJ0mKBg9o1d/Ht6SWrWKvI+/Ob
3AqIkXmgLW7Ow0C11PK9HJ73XCF3XNb3nZKClbX6cAkDj7N8NY4UfuQ1+r1widBM4GBD
nlCUvtrR1tVC/L+3NG4elw/3ZxlvASHGYNmD9LVnt2zDOWfuvYnoinrYnEBboea7Stsb
AmdQgtgKGiCeC/Ov1oHeEioCI7ba3+dxWO6sZhmjzpca5UywJn/3+LNXabcEui4aSGPM
tpOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1685637587; x=1688229587;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=BAHgbKUGLDFGyzp+XWYZ2sseIunYBsYQIO/Xldf05CU=;
b=WsDtJ6385JJ0ptrGQ12CrYqfHVOFuygdkAhTPMI122JlKEGk09Jv37+j2mIFMKsqqq
s85XgvJqTprQ34ZHQAawzkaefy1nHYDaM6b/1bTUC8dwgYHLxs8f9+ATyj+hqQSsVbBG
BhLj8i19q0beqcHRWk1Ba4K1cIaFsoNkWWsHfzNpnOKD96GtIPkeTjT7lW3qHcRKOaXt
Xtdww929PTjuPP4C/TsZWg1hiOLQf75R5L+uV+dXUezc5zDnXZXHvzhf/4mlHqlF2dT9
ilH1C1eMCWymPb6y+oqAyw7Ye43QSngw5MjBYGnPZarNAoqOEBGb6zBvvilejpFVnQkh
24kA==
X-Gm-Message-State: AC+VfDyEHsjSiNzsdLu3vlW6TtsDxBD3ooT9dQfsRmxv16EoF0lUxkCO
CK2XVKjXIGE6rUVG0pt/V9gb
X-Google-Smtp-Source:
ACHHUZ77Hvcyy/LhNWPZBGSZ2qUN6+7BPRkk03iorDwp2wOt2Mtg1w9NrwyWpOHSK+Sam8bl4ZhCTw==
X-Received: by 2002:a05:6a00:2184:b0:64a:2dd6:4f18 with SMTP id
h4-20020a056a00218400b0064a2dd64f18mr7536124pfi.13.1685637586895;
Thu, 01 Jun 2023 09:39:46 -0700 (PDT)
Received: from localhost.localdomain ([117.217.186.123])
by smtp.gmail.com with ESMTPSA id
a9-20020aa78649000000b0064f83595bbcsm5273630pfo.58.2023.06.01.09.39.43
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 01 Jun 2023 09:39:46 -0700 (PDT)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com
Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, steev@kali.org,
quic_srichara@quicinc.com,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v3 8/8] PCI: qcom: Do not advertise hotplug capability for IP
v2.1.0
Date: Thu, 1 Jun 2023 22:09:00 +0530
Message-Id: <20230601163900.15500-9-manivannan.sadhasivam@linaro.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230601163900.15500-1-manivannan.sadhasivam@linaro.org>
References: <20230601163900.15500-1-manivannan.sadhasivam@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-arm-msm.vger.kernel.org>
X-Mailing-List: linux-arm-msm@vger.kernel.org
|
| Series |
PCI: qcom: Do not advertise hotplug capability
|
expand
|
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 612266fb849a..7a87a47eb7ed 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -438,6 +438,8 @@ static int qcom_pcie_post_init_2_1_0(struct qcom_pcie *pcie) writel(CFG_BRIDGE_SB_INIT, pci->dbi_base + AXI_MSTR_RESP_COMP_CTRL1); + qcom_pcie_clear_hpc(pcie->pci); + return 0; }
SoCs making use of Qcom PCIe controller IP v2.1.0 do not support hotplug functionality. But the hotplug capability bit is set by default in the hardware. This causes the kernel PCI core to register hotplug service for the controller and send hotplug commands to it. But those commands will timeout generating messages as below during boot and suspend/resume. [ 5.782159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) [ 5.810161] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2048 msec ago) [ 7.838162] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2020 msec ago) [ 7.870159] pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x07c0 (issued 2052 msec ago) This not only spams the console output but also induces a delay of a couple of seconds. To fix this issue, let's clear the HPC bit in PCI_EXP_SLTCAP register as a part of the post init sequence to not advertise the hotplug capability for the controller. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/pci/controller/dwc/pcie-qcom.c | 2 ++ 1 file changed, 2 insertions(+)