| Message ID | 20230602073025.22884-4-mario.limonciello@amd.com |
|---|---|
| State | Accepted |
| Commit | b77505ed8a885c67a589c049c38824082a569068 |
| Headers | show |
| Series | [v4,1/4] include/linux/suspend.h: Only show pm_pr_dbg messages at suspend/resume | expand |
Hi, On 6/2/23 09:30, Mario Limonciello wrote: > Using pm_pr_dbg() allows users to toggle `/sys/power/pm_debug_messages` > as a single knob to turn on messages that amd-pmc can emit to aid in > any s2idle debugging. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Thanks, patch looks good to me. Here is my ack for merging this through the linux-pm tree: Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/platform/x86/amd/pmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c > index 427905714f79..1304cd6f13f6 100644 > --- a/drivers/platform/x86/amd/pmc.c > +++ b/drivers/platform/x86/amd/pmc.c > @@ -543,7 +543,7 @@ static int amd_pmc_idlemask_read(struct amd_pmc_dev *pdev, struct device *dev, > } > > if (dev) > - dev_dbg(pdev->dev, "SMU idlemask s0i3: 0x%x\n", val); > + pm_pr_dbg("SMU idlemask s0i3: 0x%x\n", val); > > if (s) > seq_printf(s, "SMU idlemask : 0x%x\n", val); > @@ -769,7 +769,7 @@ static int amd_pmc_verify_czn_rtc(struct amd_pmc_dev *pdev, u32 *arg) > > *arg |= (duration << 16); > rc = rtc_alarm_irq_enable(rtc_device, 0); > - dev_dbg(pdev->dev, "wakeup timer programmed for %lld seconds\n", duration); > + pm_pr_dbg("wakeup timer programmed for %lld seconds\n", duration); > > return rc; > }
diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 427905714f79..1304cd6f13f6 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -543,7 +543,7 @@ static int amd_pmc_idlemask_read(struct amd_pmc_dev *pdev, struct device *dev, } if (dev) - dev_dbg(pdev->dev, "SMU idlemask s0i3: 0x%x\n", val); + pm_pr_dbg("SMU idlemask s0i3: 0x%x\n", val); if (s) seq_printf(s, "SMU idlemask : 0x%x\n", val); @@ -769,7 +769,7 @@ static int amd_pmc_verify_czn_rtc(struct amd_pmc_dev *pdev, u32 *arg) *arg |= (duration << 16); rc = rtc_alarm_irq_enable(rtc_device, 0); - dev_dbg(pdev->dev, "wakeup timer programmed for %lld seconds\n", duration); + pm_pr_dbg("wakeup timer programmed for %lld seconds\n", duration); return rc; }
Using pm_pr_dbg() allows users to toggle `/sys/power/pm_debug_messages` as a single knob to turn on messages that amd-pmc can emit to aid in any s2idle debugging. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/platform/x86/amd/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)