| Message ID | 20230526192210.3146896-3-bhupesh.sharma@linaro.org |
|---|---|
| State | Accepted |
| Commit | fbac8ceb441508a0100888fd62f98c32a1d9f506 |
| Headers | show |
| Series | arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs | expand |
On 26/05/2023 21:22, Bhupesh Sharma wrote: > Since SM8450 BAM DMA engine supports five iommu entries, > increase the maxItems in the iommu property section, without > which 'dtbs_check' reports the following error: > > arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb: > dma-controller@1dc4000: iommus: is too long > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Tested-by: Anders Roxell <anders.roxell@linaro.org> > Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > index c663b6102f50..5636d38f712a 100644 > --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > @@ -44,7 +44,7 @@ properties: > > iommus: > minItems: 1 > - maxItems: 4 > + maxItems: 5 This needs at least 6 (sm8250). Best regards, Krzysztof
On 26/05/2023 21:22, Bhupesh Sharma wrote: > Since SM8450 BAM DMA engine supports five iommu entries, > increase the maxItems in the iommu property section, without > which 'dtbs_check' reports the following error: > > arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb: > dma-controller@1dc4000: iommus: is too long Also, please drop error message, because it is not true. The files do not have such device node, so you cannot have such warning. Please rewrite the commit msg to explain that certain devices, e.g. sm8250, use more iommus. Best regards, Krzysztof
Hi Krzysztof, On 6/18/23 2:09 PM, Krzysztof Kozlowski wrote: > On 26/05/2023 21:22, Bhupesh Sharma wrote: >> Since SM8450 BAM DMA engine supports five iommu entries, >> increase the maxItems in the iommu property section, without >> which 'dtbs_check' reports the following error: >> >> arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb: >> dma-controller@1dc4000: iommus: is too long > > Also, please drop error message, because it is not true. The files do > not have such device node, so you cannot have such warning. > > Please rewrite the commit msg to explain that certain devices, e.g. > sm8250, use more iommus. I have sent a v9 (which can be seen here: <https://lore.kernel.org/linux-arm-msm/20230630082230.2264698-1-bhupesh.sharma@linaro.org/>), which addresses your review comments shared on v8. Please help review. Thanks, Bhupesh
diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml index c663b6102f50..5636d38f712a 100644 --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml @@ -44,7 +44,7 @@ properties: iommus: minItems: 1 - maxItems: 4 + maxItems: 5 num-channels: $ref: /schemas/types.yaml#/definitions/uint32
Since SM8450 BAM DMA engine supports five iommu entries, increase the maxItems in the iommu property section, without which 'dtbs_check' reports the following error: arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb: dma-controller@1dc4000: iommus: is too long Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Tested-by: Anders Roxell <anders.roxell@linaro.org> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)