| Message ID | 1464142175-32724-1-git-send-email-Wei.Chen@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Hi Wei, On 25/05/16 03:09, Wei Chen wrote: > The original affinity shift bits algorithm in AFFINITY_MASK is buggy, > it could not generate correct affinity shift bits of level3. > The macro MPIDR_LEVEL_SHIFT can calculate level3 affinity shift bits > correctly. We use this macro in AFFINITY_MASK to generate correct > mask for level3. > Signed-off-by: Wei Chen <Wei.Chen@linaro.org> Reviewed-by: Julien Grall <julien.grall@arm.com> Regards,
diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h index 7de9c8e..b4cce7e 100644 --- a/xen/include/asm-arm/processor.h +++ b/xen/include/asm-arm/processor.h @@ -21,7 +21,6 @@ #define MPIDR_HWID_MASK _AC(0xffffff,U) #define MPIDR_INVALID (~MPIDR_HWID_MASK) #define MPIDR_LEVEL_BITS (8) -#define AFFINITY_MASK(level) ~((_AC(0x1,U) << ((level) * MPIDR_LEVEL_BITS)) - 1) /* @@ -37,6 +36,8 @@ #define MPIDR_AFFINITY_LEVEL(mpidr, level) \ ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK) +#define AFFINITY_MASK(level) ~((_AC(0x1,UL) << MPIDR_LEVEL_SHIFT(level)) - 1) + /* TTBCR Translation Table Base Control Register */ #define TTBCR_EAE _AC(0x80000000,U) #define TTBCR_N_MASK _AC(0x07,U)
The original affinity shift bits algorithm in AFFINITY_MASK is buggy, it could not generate correct affinity shift bits of level3. The macro MPIDR_LEVEL_SHIFT can calculate level3 affinity shift bits correctly. We use this macro in AFFINITY_MASK to generate correct mask for level3. Signed-off-by: Wei Chen <Wei.Chen@linaro.org> --- xen/include/asm-arm/processor.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)